Revert "Age fallback using origin_server_ts instead of 0" #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 685ef79.
t3chguy
approved these changes
Nov 3, 2023
toger5
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
I think reverting for now makes sense.
Sorry for all the pain this caused.
Although Midhun's fix could be the better thing to merge. So we could also take the risk and see if it then works.
But we dont have to rush this one. Maybe its best unblocking everyone for sure (by reverting) and then retesting in a new pr.
t3chguy
deleted the
revert-3839-toger5/better-fallback-for-unavailabel-event-age
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3839.
This turns out to have caused test failures (element-hq/element-web#26500), and there is debate about what the correct fix is.
Fixes element-hq/element-web#26500
This change is marked as an internal change (Task), so will not be included in the changelog.