Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Age fallback using origin_server_ts instead of 0 #3839

Merged
merged 10 commits into from
Nov 2, 2023
Merged

Age fallback using origin_server_ts instead of 0 #3839

merged 10 commits into from
Nov 2, 2023

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Oct 31, 2023 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Age fallback using origin_server_ts instead of 0 (#3839). Contributed by @toger5.

@toger5 toger5 requested review from a team as code owners October 31, 2023 13:53
@toger5 toger5 requested review from dbkr and richvdh October 31, 2023 13:53
@toger5
fix tests
dd0e67c 
tests now also rely on localTimestamp. So this need to be mocked as well

Signed-off-by: Timo K <[email protected]>
@toger5 toger5 requested a review from dbkr October 31, 2023 17:14
@richvdh richvdh removed their request for review November 1, 2023 09:19
@toger5 toger5 added the T-Defect label Nov 2, 2023
toger5 added 3 commits November 2, 2023 10:42
@toger5
fix tests and cleanup
37af45b 
Signed-off-by: Timo K <[email protected]>
@toger5
format
6e010d4 
Signed-off-by: Timo K <[email protected]>
@toger5
make things simpler by calculating localTimestamp
b7c0467 
from getLocalAge

Signed-off-by: Timo K <[email protected]>
@toger5 toger5 requested a review from dbkr November 2, 2023 10:36
@toger5 toger5 added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 2, 2023
@toger5 toger5 added this pull request to the merge queue Nov 2, 2023
Merged via the queue into develop with commit 685ef79 Nov 2, 2023
19 checks passed
@toger5 toger5 deleted the toger5/better-fallback-for-unavailabel-event-age branch November 2, 2023 14:05
@MidhunSureshR MidhunSureshR mentioned this pull request Nov 3, 2023
Merged
@richvdh richvdh mentioned this pull request Nov 3, 2023
Closed
richvdh added a commit that referenced this pull request Nov 3, 2023
@richvdh
Revert "Age fallback using origin_server_ts instead of 0 (#3839)"
aef382b 
This reverts commit 685ef79.
@richvdh richvdh mentioned this pull request Nov 3, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 3, 2023
@richvdh
Revert "Age fallback using origin_server_ts instead of 0 (#3839)" (#3853
5bc132a 
)

This reverts commit 685ef79.
@toger5 toger5 mentioned this pull request Nov 6, 2023
Merged
3 tasks
@t3chguy t3chguy added the X-Reverted PR has been reverted label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr Awaiting requested review from dbkr

Assignees
No one assigned
Labels
T-Defect X-Reverted PR has been reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toger5 @dbkr @t3chguy