Element-R: Stub interface for secure key backup #3623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/element-r/43_securebackup_interface
branch
from
8bd05b4
to
1c9ebcc
Compare
I need a way to mark devices as trusted for the backup tests.
The user and device IDs are in the test data, so no need to pass them in
Make it use the CryptoApi rather than legacy `MatrixClient.crypto`, and use a pre-signed backup instead of requiring a "blindlySignAnything" method.
richvdh
force-pushed
the
rav/element-r/43_securebackup_interface
branch
from
1c9ebcc
to
2f4c1a6
Compare
richvdh
changed the base branch from
develop
to
rav/element-r/44_set_device_verified
richvdh
requested review from
t3chguy and
florianduros
and removed request for
a team
3 tasks
richvdh
commented
Jul 26, 2023
|
Ugh, I don't think I want to do this after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3624
I realised that the BackupManager interface is only used within the js-sdk, so I have made it properly internal.
Closes https://github.com/vector-im/crypto-internal/issues/105
This change is marked as an internal change (Task), so will not be included in the changelog.