Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CryptoApi.getActiveSessionBackupVersion() #3555

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Add CryptoApi.getActiveSessionBackupVersion() #3555

merged 4 commits into from
Jul 28, 2023

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jul 7, 2023 •
edited by github-actions bot
Loading

... which replaces which replaces BackupManager.getKeyBackupEnabled() and BackupManager.version

Fixes https://github.com/vector-im/crypto-internal/issues/106

Based on #3631

This change is marked as an internal change (Task), so will not be included in the changelog.

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner July 7, 2023 09:12
@BillCarsonFr BillCarsonFr requested review from t3chguy and SimonBrandner and removed request for a team July 7, 2023 09:12
t3chguy
t3chguy requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The # breaks Github's autoclose behaviour, also please fix the PR title and have CI passing before requesting review

@BillCarsonFr BillCarsonFr changed the title Valere/rust backup status api Add SecureBackup.getKeyBackupStatus() which replaces getKeyBackupEnabled and version Jul 7, 2023
@richvdh richvdh mentioned this pull request Jul 7, 2023
Closed
3 tasks
@BillCarsonFr BillCarsonFr mentioned this pull request Jul 7, 2023
Closed
3 tasks
@BillCarsonFr BillCarsonFr marked this pull request as draft July 8, 2023 19:25
@richvdh richvdh force-pushed the valere/rust_backup_status_api branch from 9f1c9f1 to 352c29e Compare July 26, 2023 16:53
@richvdh richvdh changed the base branch from valere/rust_backup_support_wp0 to rav/element-r/43_securebackup_interface July 26, 2023 16:54
@richvdh richvdh changed the title Add SecureBackup.getKeyBackupStatus() which replaces getKeyBackupEnabled and version Add SecureBackup.getKeyBackupStatus() Jul 26, 2023
@richvdh richvdh force-pushed the valere/rust_backup_status_api branch from 352c29e to 2c2fd4e Compare July 26, 2023 20:16
@richvdh richvdh added the T-Task Tasks for the team like planning label Jul 26, 2023
@richvdh richvdh changed the title Add SecureBackup.getKeyBackupStatus() Add SecureBackup.getActiveBackupVersion() Jul 26, 2023
@richvdh richvdh changed the title Add SecureBackup.getActiveBackupVersion() Add CryptoApi.getActiveSessionBackupVersion() Jul 26, 2023
@richvdh richvdh force-pushed the valere/rust_backup_status_api branch from 6eb8d06 to 5da8144 Compare July 27, 2023 09:52
@richvdh richvdh changed the base branch from rav/element-r/43_securebackup_interface to rav/element-r/45_backup_integ_test July 27, 2023 10:15
@richvdh richvdh marked this pull request as ready for review July 27, 2023 15:23
Base automatically changed from rav/element-r/45_backup_integ_test to develop July 27, 2023 15:35
@richvdh richvdh force-pushed the valere/rust_backup_status_api branch from 94582a5 to 938e9af Compare July 27, 2023 16:24
@richvdh richvdh mentioned this pull request Jul 27, 2023
Merged
@richvdh richvdh requested a review from t3chguy July 27, 2023 19:54
t3chguy
t3chguy reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonar looks unhappy

@richvdh
Revert unnecessary change
3e7da2e 
we can do this later, once we have better test coverage
@richvdh
Copy link
Member

richvdh commented Jul 27, 2023

Better now

@richvdh richvdh requested a review from t3chguy July 27, 2023 22:43
@richvdh richvdh added this pull request to the merge queue Jul 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 28, 2023
@richvdh richvdh added this pull request to the merge queue Jul 28, 2023
Merged via the queue into develop with commit 6d28154 Jul 28, 2023
20 checks passed
@richvdh richvdh deleted the valere/rust_backup_status_api branch July 28, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@SimonBrandner SimonBrandner Awaiting requested review from SimonBrandner SimonBrandner is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillCarsonFr @richvdh @t3chguy