Key backup: clean up SecureKeyBackup.prepareKeyBackupVersion #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
requested review from
florianduros,
kerryarchibald and
richvdh
and removed request for
a team
I need a way to mark devices as trusted for the backup tests.
The user and device IDs are in the test data, so no need to pass them in
Make it use the CryptoApi rather than legacy `MatrixClient.crypto`, and use a pre-signed backup instead of requiring a "blindlySignAnything" method.
richvdh
force-pushed
the
valere/rust_backup_status_api
branch
from
9f1c9f1
to
352c29e
Compare
richvdh
force-pushed
the
valere/rust_backup_status_api
branch
from
352c29e
to
2c2fd4e
Compare
…st_backup_status_api
…st_backup_status_api
richvdh
force-pushed
the
valere/backup_prepareKeyBackupVersion_api
branch
from
9610aac
to
a3234c3
Compare
richvdh
force-pushed
the
valere/rust_backup_status_api
branch
2 times, most recently
from
94582a5
to
938e9af
Compare
|
Per my recent updates on https://github.com/vector-im/crypto-internal/issues/107: I don't think we want to do this as initially envisaged. Leaving this open for now for @BillCarsonFr to decide if there is anything salvageable, but I suspect not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3555
Fixes #https://github.com/vector-im/crypto-internal/issues/107
Moved prepareKeyBackupVersion() in the new SecureBackup API.
Moved also the part that was doing the signing to do it once inside this API
The SecureBackup API exposes a
prepareUnsignedKeyBackupVersion()it doesn't sign here because it would require a back reference to crypto. Instead the CryptoAPi exposes now aprepareKeyBackupVersion()that calls the backup API to get an unsigned version and then does the signing. In order to avoid breaking change the existingprepareKeyBackupVersionon backup.ts is deprecated and now calls the unsigned version.Clients are using MatrixClient.prepareKeyBackupVersion that transparantly follow the call.
Checklist
This PR currently has none of the required changelog labels.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.