Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Room.getLastLiveEvent and Room.getLastThread #3321

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Apr 26, 2023

Part of element-hq/element-web#25207

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Notes: Added Room.getLastLiveEvent and Room.getLastThread. Deprecated Room.lastThread in favour of Room.getLastThread.


Here's what your changelog entry will look like:

✨ Features

  • Added Room.getLastLiveEvent and Room.getLastThread. Deprecated Room.lastThread in favour of Room.getLastThread. (#3321).

src/models/room.ts Outdated Show resolved Hide resolved
@weeman1337 weeman1337 changed the title Add room.getLastLiveEvent and remove room.lastThread Add Room#getLastLiveEvent and Room#getLastThread Apr 27, 2023
@weeman1337 weeman1337 changed the title Add Room#getLastLiveEvent and Room#getLastThread Add Room.getLastLiveEvent and Room.getLastThread Apr 27, 2023
@weeman1337
Copy link
Contributor Author

SonarCloud Code Analysis Failing after 1m — Quality Gate failed

image

→ Ignore SonarCloud in this case?

@weeman1337 weeman1337 marked this pull request as ready for review April 27, 2023 10:07
@weeman1337 weeman1337 requested a review from a team as a code owner April 27, 2023 10:07
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@weeman1337 weeman1337 added this pull request to the merge queue Apr 27, 2023
Merged via the queue into develop with commit 1e041a2 Apr 27, 2023
@weeman1337 weeman1337 deleted the weeman1337/room-last-live-event branch April 27, 2023 11:59
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Jul 31, 2023
* Deprecate MatrixClient::resolveRoomAlias ([\matrix-org#3316](matrix-org#3316)).
* add client method to remove pusher ([\matrix-org#3324](matrix-org#3324)). Contributed by @kerryarchibald.
* Implement MSC 3981 ([\matrix-org#3248](matrix-org#3248)). Fixes element-hq/element-web#25021. Contributed by @justjanne.
* Added `Room.getLastLiveEvent` and `Room.getLastThread`. Deprecated `Room.lastThread` in favour of `Room.getLastThread`. ([\matrix-org#3321](matrix-org#3321)).
* Element-R: wire up device lists ([\matrix-org#3272](matrix-org#3272)). Contributed by @florianduros.
* Node 20 support ([\matrix-org#3302](matrix-org#3302)).
* Fix racing between one-time-keys processing and sync ([\matrix-org#3327](matrix-org#3327)). Fixes element-hq/element-web#25214. Contributed by @florianduros.
* Fix lack of media when a user reconnects ([\matrix-org#3318](matrix-org#3318)).
* Fix TimelineWindow getEvents exploding if no neigbouring timeline ([\matrix-org#3285](matrix-org#3285)). Fixes element-hq/element-web#25104.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants