Fix lack of media when a user reconnects #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes broken media when someone reconnects to the call after a forced disconnect (when their old call gets replaced immediately by a new call). We listen for changes in the call feeds and the tearing down of the feeds for the old call caused us to remove the feed for the new call. Also adds the call to the calls map before it'as initialised, such that it's the active call for the user/device when the feedsChanged event arrives, otherwise we'll ignore the event.
EnricoSchw
approved these changes
Apr 26, 2023
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Jul 31, 2023
* Deprecate MatrixClient::resolveRoomAlias ([\matrix-org#3316](matrix-org#3316)). * add client method to remove pusher ([\matrix-org#3324](matrix-org#3324)). Contributed by @kerryarchibald. * Implement MSC 3981 ([\matrix-org#3248](matrix-org#3248)). Fixes element-hq/element-web#25021. Contributed by @justjanne. * Added `Room.getLastLiveEvent` and `Room.getLastThread`. Deprecated `Room.lastThread` in favour of `Room.getLastThread`. ([\matrix-org#3321](matrix-org#3321)). * Element-R: wire up device lists ([\matrix-org#3272](matrix-org#3272)). Contributed by @florianduros. * Node 20 support ([\matrix-org#3302](matrix-org#3302)). * Fix racing between one-time-keys processing and sync ([\matrix-org#3327](matrix-org#3327)). Fixes element-hq/element-web#25214. Contributed by @florianduros. * Fix lack of media when a user reconnects ([\matrix-org#3318](matrix-org#3318)). * Fix TimelineWindow getEvents exploding if no neigbouring timeline ([\matrix-org#3285](matrix-org#3285)). Fixes element-hq/element-web#25104.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes broken media when someone reconnects to the call after a forced disconnect (when their old call gets replaced immediately by a new call). We listen for changes in the call feeds and the tearing down of the feeds for the old call caused us to remove the feed for the new call.
Also adds the call to the calls map before it'as initialised, such that it's the active call for the user/device when the feedsChanged event arrives, otherwise we'll ignore the event.
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes