Complete MXCryptoV2 implementation #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/complete_crypto
branch
from
974157e
to
befcd80
Compare
Anderas
requested review from
a team and
ismailgulek
and removed request for
a team
Codecov ReportBase: 15.90% // Head: 36.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1620 +/- ##
============================================
+ Coverage 15.90% 36.37% +20.46%
============================================
Files 577 577
Lines 90876 90876
Branches 38355 39535 +1180
============================================
+ Hits 14454 33056 +18602
+ Misses 75953 56837 -19116
- Partials 469 983 +514
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ismailgulek
approved these changes
Oct 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large final round of changes to the
MXCryptoV2implementation to make it ready for alpha testing. The changes in this PR include:MXCryptoprotocol and intoMXLegacyCryptoimplementation, as they are not needed with V2 (the functionality is handled internally byCryptoMachine)MXCryptowith nullability to make swift code safer and more explicit. At times this means making more things nullable than necessary just to handle any rogue objective-cnilsMatrixSDKCryptoto the latest version which includesEncryptionSettingMXCryptoV2to group related functionality (apologies for impact on code review)