-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CryptoV2 changes #1622
CryptoV2 changes #1622
Conversation
24d588f
to
2757764
Compare
Codecov ReportBase: 36.37% // Head: 15.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## andy/complete_crypto #1622 +/- ##
=========================================================
- Coverage 36.37% 15.88% -20.50%
=========================================================
Files 577 578 +1
Lines 90876 91061 +185
Branches 39535 38397 -1138
=========================================================
- Hits 33056 14464 -18592
- Misses 56837 76118 +19281
+ Partials 983 479 -504
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3dba9c1
to
e06ca9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Do you need to add a changelog for this?
Its pretty much bugfixes for #1620, I just did not want to do it in the same PR for readability, so I don't think changelog is necessary |
A number of changes to rust-based Crypto V2 after extensive testing with polyjuice:
VerificationState
on decryption result to display trusted / untrusted sessions