-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup CI #514
Fixup CI #514
Conversation
update galata references |
is it possible to easily look at the differences in the generated images? I suspect that were catching a styling change in matplotlib latest |
You can download the test artifacts on this page https://github.com/matplotlib/ipympl/actions/runs/4122954626 (bottom of the page -> ui-test-output file). It will contain the expected image, the actual image and the diff. There seems to be a slight difference in the font rendering of the axis labels.
Yes, I was thinking the same. It seems to only happen on Ubuntu. Because it's a very slight difference I tried to change the threshold for the diff, without success. |
I think that there have been a bunch of changes to the font system recently. I almost wonder if this is surfacing a very subtle bug upstream |
@martinRenou what do you think about merging this now and fixing up the ubuntu latest in the future? As it stands this allows us to run tests, which we otherwise cant. which would be helpful for #517 and #478 |
That's fine with me, half working CI is better than non working one |
No description provided.