Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure throttling does not break capture_scroll #478

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

ianhi
Copy link
Collaborator

@ianhi ianhi commented Jul 16, 2022

Since we started throttling mouse events we now also throttle the capture_scroll This PR adds that as a separate EventListener that is not throttled.

@ianhi ianhi requested a review from martinRenou July 16, 2022 19:55
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch ianhi/ipympl/always-capture

@ianhi ianhi closed this Oct 19, 2022
@ianhi ianhi reopened this Oct 19, 2022
@ianhi ianhi mentioned this pull request Feb 15, 2023
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ianhi ianhi merged commit 92ad7e5 into matplotlib:main Feb 15, 2023
@ianhi ianhi deleted the always-capture branch February 15, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants