Update release info #57

davidbuzinski · 2023-02-17T15:12:03Z

Update to store in tool cache with YEAR.A/B.UPDATE format
Get rid of Latest in mpm install command to fix Warning
Add mac support

src/matlab.ts

mcafaro · 2023-02-17T16:10:50Z

src/matlab.ts

+            return Promise.reject(Error(`Unable to retrieve the MATLAB release information. Contact MathWorks at [email protected] if the problem persists.`));
+        }
+    } else {
+        let nameMatch = release.toLowerCase().match(/r[0-9]{4}[a-b]/);


We aren't allowing users to specify update level?

We are, we just pull the release name and the update level out separately

Updated to warn if formatting is invalid. Using latest as default in this case

davidbuzinski · 2023-02-17T21:50:44Z

src/matlab.ts

+        // Notify user if Update version format is invalid
+        if (release.trim() !== name) {
+            const invalidUpdate = release.replace(name, "");
+            core.info(`Update version ${invalidUpdate} is invalid. Defaulting to latest update.`);


@mw-hrastega Would appreciate some feedback on this info message. For context: This is what we show users if they add an update version to their release in an invalid format.

For example, mpm requires format like R2021aU2 for R2021 update 2. If they put R2021aUpdate2 or R2021aSomeNonsense they will see this.

How about this?

Defaulting to the latest update release because ${} is not a valid release name.

Reference page: https://www.mathworks.com/help/matlab/ref/matlabrelease.html

mcafaro · 2023-02-17T22:50:04Z

src/matlab.ts

+        // Notify user if Update version format is invalid
+        if (release.trim() !== name) {
+            const invalidUpdate = release.replace(name, "");
+            core.info(`Defaulting to the latest update release because ${invalidUpdate} is not a valid update release name.`);


I would consider making this an error rather than a warning because it will be easily missed in a CI log.

mcafaro · 2023-02-21T13:18:56Z

src/matlab.ts

+        // Notify user if Update version format is invalid
+        if (trimmedRelease !== name && trimmedRelease !== "latest") {
+            const invalidUpdate = trimmedRelease.replace(name, "");
+            return Promise.reject(Error(`Defaulting to the latest update release because ${invalidUpdate} is not a valid update release name.`));


No longer defaulting to latest if this is now an error right?

mcafaro

* Invoke installer for private repo support * Disable automatic activation * Fix failing unit test to account for addition call * Add environment variables to workflow * Disable R2020a workflow; only R2020b for now * Build 82c7ee1 * Build for v1.0.1 * Remove -r from BaT workflow * First change * Use mpm * Update action.yml * Update bat.yml * Update install.ts * Add to path * Update index.ts * Pass in products * Add products input * Update bat.yml * Cache installs * Update bat.yml * Update install.ts * Update install.ts * Update install.ts * Update install.ts * Enable caching * Cache in the right place * Print the key * More display tweaks * Get the key right * Cache * merge changes for v2-beta (#50) * v2-beta bugfix (#52) * adding tests to catch bugs * updating unit tests and source code * updating workflow to use 2nd release * fixing update level logic * update level deps script workaround * testing no-op on existing install * add output * Update bat.yml * Update bat.yml * Update bat.yml * Update src/matlab.ts Co-authored-by: Mark Cafaro <[email protected]> * Update matlab.Release and removed usExisting from destination * updated release info to fix inconsistency * changed output name to matlabroot * fixng pipeline syntax * missing colon in yml * updating naming and fixing missing simulink in bat workflow * changing some variable names for clarity Co-authored-by: Mark Cafaro <[email protected]> * Update release info (#57) * Restrict supported releases (#65) * Add cache input to leverage Github Actions cache for v2 (#73) * added cache-save and updated build. TODO: cache-restore * added cache restore * fixing release type conversion and bool type conversion * add unit tests * fixing path and cache hit issues * add architecture to cache key and fix description * addressed review feedback * updated MatlabPath state 'type' * updated missed copyrights * changing back latest URL * update cache input description * Fix mpm mac windows v2-beta (#77) * no more unzip mpm * test no windows * update url * try with .exe extension? * fail slow * update url * try cacheFile to fix file location * take out bad secrets * undo bad string interp * trying fix linux mac * use runcommand * use runcommand * try to specify directory * error if no runner temp found * Updated to check if sudo command is available * Add tests * Switch to registry.npmjs.org * Clean up change * Update copyright * Update to check if which returns empty string * merge rc0 changes to mpm branch (#83) * initial commit * npm audit fix * add batch to tc * chmod matlab-batch * rearranging chmod * still wrangling chmod * remove pct * remove PCT from defaults * update tests * cache fix for support packages * make sure support packages path is in cachePaths if defined * add log for supportPackagesPath * capitalize release dir * had wrong default dir * testing windows thing * remove log. use tmpdir for windows * applying mpm fixes for mac & windows * initial commit * npm audit fix * add batch to tc * chmod matlab-batch * rearranging chmod * still wrangling chmod * remove pct * remove PCT from defaults * update tests * cache fix for support packages * make sure support packages path is in cachePaths if defined * add log for supportPackagesPath * capitalize release dir * had wrong default dir * testing windows thing * remove log. use tmpdir for windows * applying mpm fixes for mac & windows * Merge windows optimization to v2-rc0 * improve os specific cache dir implemenation * try to link after install * symlink wrong direction? * update toolcache impl * forgot .keep * forgot dist * fix typo * debug * more debug idk * forgot recursive * seeing whatever is going on with .complete file * add tests for windows toolcache optimization * prep for merge * one more update before merge * Update bat.yml to v2-rc0 for build until release * address sam's feedback * address mark's feedback * fix error message * switch statement sugar Co-authored-by: Mark Cafaro <[email protected]> * Accept any number of spaces in product list Co-authored-by: Mark Cafaro <[email protected]> --------- Co-authored-by: sameagen <[email protected]> Co-authored-by: Mark Cafaro <[email protected]> * Update action node version (#84) * init update * update bat.yml * update bat.yml * review comments * updating README in preparation for matlab-actions/setup-matlab@v2 (#88) * Update README.md replacing v1 with v2 * removing text on platform restrictions * replacing a verb * updating the action description * replacing 20b with 21a * updating products description * updating the cache description * adding a placeholder section * adding missing trademark symbol * update the first example description * removing a code block * updating the last example description * addressing review feedback * Fix a typo. Co-authored-by: Mark Cafaro <[email protected]> --------- Co-authored-by: Mark Cafaro <[email protected]> --------- Co-authored-by: Johan Pereira <[email protected]> Co-authored-by: Andy Campbell <[email protected]> Co-authored-by: Mark Cafaro <[email protected]> Co-authored-by: sameagen <[email protected]> Co-authored-by: sameagen-MW <[email protected]> Co-authored-by: mw-hrastega <[email protected]>

davidbuzinski and others added 12 commits December 20, 2022 09:25

moving to latest.txt and descriptive semantic version

dd3a80d

Update properties.json

504d1fb

Update properties.json

7a88ea5

Update matlab.ts

153631a

Update matlab.unit.test.ts

777e3af

Update README.md

0b039d5

testing mpm mac

777c856

more trying maci mpm

73ec28a

testing werid thing with mac destination

2d1c710

oops didn't update signature everywhere

a3dccec

test coverage and small fixes

a4493b9

fix Latest warning

e000c1e

davidbuzinski requested review from mcafaro and sameagen-MW February 17, 2023 15:12

mcafaro reviewed Feb 17, 2023

View reviewed changes

fixed spacing and added more leniency on update number

d7a46c3

davidbuzinski requested a review from mcafaro February 17, 2023 16:20

warn for invalid update version format

99c1992

davidbuzinski commented Feb 17, 2023

View reviewed changes

update info message for invalid update release name

fd78a03

mw-hrastega approved these changes Feb 17, 2023

View reviewed changes

mcafaro reviewed Feb 17, 2023

View reviewed changes

error instead of warn on invalid update format

b7f41b0

mcafaro reviewed Feb 21, 2023

View reviewed changes

Update matlab.ts

849649c

mcafaro approved these changes Feb 21, 2023

View reviewed changes

davidbuzinski merged commit 180c8e5 into mpm Feb 21, 2023

davidbuzinski deleted the update-release-info branch February 21, 2023 15:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update release info #57

Update release info #57

davidbuzinski commented Feb 17, 2023

mcafaro Feb 17, 2023

davidbuzinski Feb 17, 2023

davidbuzinski Feb 17, 2023

davidbuzinski Feb 17, 2023

mw-hrastega Feb 17, 2023

mcafaro Feb 17, 2023

mcafaro Feb 21, 2023

mcafaro left a comment

Update release info #57

Update release info #57

Conversation

davidbuzinski commented Feb 17, 2023

mcafaro Feb 17, 2023

Choose a reason for hiding this comment

davidbuzinski Feb 17, 2023

Choose a reason for hiding this comment

davidbuzinski Feb 17, 2023

Choose a reason for hiding this comment

davidbuzinski Feb 17, 2023

Choose a reason for hiding this comment

mw-hrastega Feb 17, 2023

Choose a reason for hiding this comment

mcafaro Feb 17, 2023

Choose a reason for hiding this comment

mcafaro Feb 21, 2023

Choose a reason for hiding this comment

mcafaro left a comment

Choose a reason for hiding this comment