v2-beta bugfix #52
Merged
v2-beta bugfix #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidbuzinski
commented
Dec 5, 2022
•
davidbuzinski
commented
- Fix the space-separated input bug
- Remove duplicates from install list
- Allow specifying update version (ex: R2022aU2)
- Add matlabroot as action output
- NoOp on existing install
mcafaro
reviewed
Dec 5, 2022
mcafaro
reviewed
Dec 6, 2022
apuvvala-mw
reviewed
Dec 6, 2022
mcafaro
approved these changes
Dec 6, 2022
davidbuzinski
added a commit
that referenced
this pull request
Feb 6, 2024
* Invoke installer for private repo support * Disable automatic activation * Fix failing unit test to account for addition call * Add environment variables to workflow * Disable R2020a workflow; only R2020b for now * Build 82c7ee1 * Build for v1.0.1 * Remove -r from BaT workflow * First change * Use mpm * Update action.yml * Update bat.yml * Update install.ts * Add to path * Update index.ts * Pass in products * Add products input * Update bat.yml * Cache installs * Update bat.yml * Update install.ts * Update install.ts * Update install.ts * Update install.ts * Enable caching * Cache in the right place * Print the key * More display tweaks * Get the key right * Cache * merge changes for v2-beta (#50) * v2-beta bugfix (#52) * adding tests to catch bugs * updating unit tests and source code * updating workflow to use 2nd release * fixing update level logic * update level deps script workaround * testing no-op on existing install * add output * Update bat.yml * Update bat.yml * Update bat.yml * Update src/matlab.ts Co-authored-by: Mark Cafaro <[email protected]> * Update matlab.Release and removed usExisting from destination * updated release info to fix inconsistency * changed output name to matlabroot * fixng pipeline syntax * missing colon in yml * updating naming and fixing missing simulink in bat workflow * changing some variable names for clarity Co-authored-by: Mark Cafaro <[email protected]> * Update release info (#57) * Restrict supported releases (#65) * Add cache input to leverage Github Actions cache for v2 (#73) * added cache-save and updated build. TODO: cache-restore * added cache restore * fixing release type conversion and bool type conversion * add unit tests * fixing path and cache hit issues * add architecture to cache key and fix description * addressed review feedback * updated MatlabPath state 'type' * updated missed copyrights * changing back latest URL * update cache input description * Fix mpm mac windows v2-beta (#77) * no more unzip mpm * test no windows * update url * try with .exe extension? * fail slow * update url * try cacheFile to fix file location * take out bad secrets * undo bad string interp * trying fix linux mac * use runcommand * use runcommand * try to specify directory * error if no runner temp found * Updated to check if sudo command is available * Add tests * Switch to registry.npmjs.org * Clean up change * Update copyright * Update to check if which returns empty string * merge rc0 changes to mpm branch (#83) * initial commit * npm audit fix * add batch to tc * chmod matlab-batch * rearranging chmod * still wrangling chmod * remove pct * remove PCT from defaults * update tests * cache fix for support packages * make sure support packages path is in cachePaths if defined * add log for supportPackagesPath * capitalize release dir * had wrong default dir * testing windows thing * remove log. use tmpdir for windows * applying mpm fixes for mac & windows * initial commit * npm audit fix * add batch to tc * chmod matlab-batch * rearranging chmod * still wrangling chmod * remove pct * remove PCT from defaults * update tests * cache fix for support packages * make sure support packages path is in cachePaths if defined * add log for supportPackagesPath * capitalize release dir * had wrong default dir * testing windows thing * remove log. use tmpdir for windows * applying mpm fixes for mac & windows * Merge windows optimization to v2-rc0 * improve os specific cache dir implemenation * try to link after install * symlink wrong direction? * update toolcache impl * forgot .keep * forgot dist * fix typo * debug * more debug idk * forgot recursive * seeing whatever is going on with .complete file * add tests for windows toolcache optimization * prep for merge * one more update before merge * Update bat.yml to v2-rc0 for build until release * address sam's feedback * address mark's feedback * fix error message * switch statement sugar Co-authored-by: Mark Cafaro <[email protected]> * Accept any number of spaces in product list Co-authored-by: Mark Cafaro <[email protected]> --------- Co-authored-by: sameagen <[email protected]> Co-authored-by: Mark Cafaro <[email protected]> * Update action node version (#84) * init update * update bat.yml * update bat.yml * review comments * updating README in preparation for matlab-actions/setup-matlab@v2 (#88) * Update README.md replacing v1 with v2 * removing text on platform restrictions * replacing a verb * updating the action description * replacing 20b with 21a * updating products description * updating the cache description * adding a placeholder section * adding missing trademark symbol * update the first example description * removing a code block * updating the last example description * addressing review feedback * Fix a typo. Co-authored-by: Mark Cafaro <[email protected]> --------- Co-authored-by: Mark Cafaro <[email protected]> --------- Co-authored-by: Johan Pereira <[email protected]> Co-authored-by: Andy Campbell <[email protected]> Co-authored-by: Mark Cafaro <[email protected]> Co-authored-by: sameagen <[email protected]> Co-authored-by: sameagen-MW <[email protected]> Co-authored-by: mw-hrastega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.