Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/debug: remove memsize to fix docker #1308

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

marcello33
Copy link
Contributor

@marcello33 marcello33 commented Aug 16, 2024

Description

In this PR we remove memsize as it is incompatible with latest go versions, preventing the app to build in docker.
Same changes have been applied in go-ethereum here.
Also, the latest commit on this branch solves some lint issues.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

@marcello33 marcello33 changed the title Remove memsize to fix docker internal/debug: remove memsize to fix docker Aug 16, 2024
@marcello33 marcello33 requested a review from a team August 16, 2024 08:01
@marcello33 marcello33 merged commit aa54ff5 into master Aug 16, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants