Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compilation with Go 1.23 #1307

Closed
yorickdowne opened this issue Aug 14, 2024 · 4 comments
Closed

Support compilation with Go 1.23 #1307

yorickdowne opened this issue Aug 14, 2024 · 4 comments

Comments

@yorickdowne
Copy link

Feature

Compilation with Go 1.23 currently fails. Go 1.22 works

26.20 go: downloading go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.49.0
26.22 go: downloading github.com/felixge/httpsnoop v1.0.4
84.03 # command-line-arguments
84.03 link: github.com/fjl/memsize: invalid reference to runtime.stopTheWorld
84.18 make: *** [Makefile:28: bor] Error 1
@yorickdowne
Copy link
Author

Upstream: fjl/memsize#5

@yorickdowne
Copy link
Author

Go team rejected the memsize author’s proposal to make memsize work with Go 1.23.

Upstream go-ethereum fixed this by removing memsize in this patch: ethereum/go-ethereum@e467577

@klestrong
Copy link

@yorickdowne
Thank you! Your post is much appreciated. I can confirm specifying Go 1.22 successfully completed the build for me and has resolved my issue in the previous ticket I posted.
#1306 (comment)

@marcello33
Copy link
Contributor

We applied the same patch from go-ethereum here
It will be eventually merged and released with the next release.
In the meantime, you can apply the workaround by changing the version in the Dockerfile.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants