-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to HB #698
Port to HB #698
Conversation
9f1f626
to
4949e3f
Compare
I needed to add a Nix overlay to let Nix know about the mathcomp -> HB dependency, then
should work |
Oh did I forget to commit something? |
@CohenCyril I'll need your help here, this is stuck on a
which I don't understand (c.f. last |
Fixed, there was a missing instance. I wonder whether this should be considered a bug of HB though? (* works *)
Check [the choiceType of set T].
(* works (no evar) *)
Check Order.IsMeetJoinDistrLattice.Build set_display (set T)
le_def lt_def (@setIC _) (@setUC _) (@setIA _) (@setUA _)
joinKI meetKU (@setIUl _) setIid.
(* fails: "Error: HB: cannot inhabit mixin Order_POrder_IsLattice on set T" *)
Fail #[export]
HB.instance Definition _ :=
Order.IsMeetJoinDistrLattice.Build set_display (set T)
le_def lt_def (@setIC _) (@setUC _) (@setIA _) (@setUA _)
joinKI meetKU (@setIUl _) setIid.
#[export]
HB.instance Definition _ : Choice (set T) := Choice.copy _ (set T).
(* now works *)
#[export]
HB.instance Definition _ :=
Order.IsMeetJoinDistrLattice.Build set_display (set T)
le_def lt_def (@setIC _) (@setUC _) (@setIA _) (@setUA _)
joinKI meetKU (@setIUl _) setIid. More generally: shouldn't an |
No, it should not, since adding new structures in the middle of the hierarchy might make some |
Just for information. --
|
@affeldt-aist no, that's also what I'm experiencing with
I indeed got further but realized I made something slightly wrong an went back "fixing" it. That's when I encoutered this issue and stopped there. Sorry, I should have put an explanatory comment. |
@CohenCyril @affeldt-aist I put a list of files currently needing porting / with someone working on them in the description of the PR on top, please edit as files become available / check boxes when you are working on one |
I would also put the name of the person working on it on the side. |
I haven't figured out weak_topologicalTypeMixin but maybe at least nbhs_of_open that will be used ought better be outisde of a builders section to stay accessible. |
It seems that often, the complicated |
I have, I will post it soon or I can show you. |
@affeldt-aist @proux01 in order to fix the |
|
9ef5ac7
to
6d5867e
Compare
Rebased and force pushed to trigger the CI. |
FYI, CI is green on 8.15, 8.16 and master (of course, there are still a few things commented out in topology.v). |
4b0233f
to
dcc30c9
Compare
2ba7e9a
to
ce002d6
Compare
ce002d6
to
ec9f433
Compare
FYI, I've merged several results (metrics for supremums and quotients) in the last few days that involve some mixins. Just a heads up to |
Thanks for the head up @zstone1 ! As @CohenCyril said, the HB port shouldn't hinder further development in the main branch, so your changes are fine. Of course, if at some point you want to help completing the HB port (you are probably the best expert of the part of the code that remains to port), that would be welcome, but certainly not an obligation. |
* add a type for finite measures - s-finite measures from branch kernels - add subprobabilities - dirac instance of probability - rm finite_measure - renaming - minor fix
Co-authored-by: Quentin Vermande <[email protected]>
- a few pinfty/ninfty -> y/Ny renamings
* Add itv.v Taking inspiration on signed.v, replacing sign by intervals. * Add interval multiplication * Add hints to automatically solve _ <= 1 goals * Test to see if usable as a replacement for prob * use notation from mathcomp_extra.v * changelog and rm redundant code * prefix duplicated identifiers --------- Co-authored-by: Reynald Affeldt <[email protected]>
porting quotient fixes
@@ -620,9 +625,10 @@ Definition measurableTypeR := salgebraType (R.-ocitv.-measurable). | |||
Definition measurableR : set (set R) := | |||
(R.-ocitv.-measurable).-sigma.-measurable. | |||
|
|||
HB.instance Definition _ := Pointed.on R. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: non forgetful inheritance detected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using measurableTypeR
instead of R
makes the warning disappear but causes problems later (in the sense that one needs to explicitly use measurableTypeR
here and there).
Is it a case of controlled/harmless non-forgetful inheritance for which the warning should be silenced?
@@ -620,9 +625,10 @@ Definition measurableTypeR := salgebraType (R.-ocitv.-measurable). | |||
Definition measurableR : set (set R) := | |||
(R.-ocitv.-measurable).-sigma.-measurable. | |||
|
|||
HB.instance Definition _ := Pointed.on R. | |||
HB.instance Definition R_isMeasurable : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non forgetful inheritance detected
Co-authored-by: Reynald Affeldt <[email protected]>
* gen exp_fun - rename to power_pow - fix doc - add scope to notation Co-authored-by: Alessandro Bruni <[email protected]> Co-authored-by: Takafumi Saikawa <[email protected]> * add lemma power12_sqrt * additional lemmas * change power_pos so that 0^0=1 - so that power_pos and exprn coincide * measurable_fun exp ln * fix chaneglog * add power_pos_intmul proposed by Pierre * fix changelog --------- Co-authored-by: Alessandro Bruni <[email protected]> Co-authored-by: Takafumi Saikawa <[email protected]> Co-authored-by: Alessandro Bruni <[email protected]>
- fixes issue #883 Co-authored-by: Alessandro Bruni <[email protected]> Co-authored-by: Takafumi Saikawa <[email protected]>
5fe9a6c
to
7c4bc43
Compare
Since we are no longer handling the HB port as a PR, try to close this to try to get CI on the branch. |
Ok, so we don't have CI on this branch. I suggest to push to the HB branch via PRs targetting it and hopefully we'll get CI in the PRs. |
Files available for porting ([x] means taken by someone)
Motivation for this change
@affeldt-aist @gares @proux01 @mkerjean port of MCA in progress (see
.nix/config.nix for the requirements)
Things done/to do
CHANGELOG_UNRELEASED.md
(do not edit former entries, only append new ones, be careful:
merge and rebase have a tendency to mess up
CHANGELOG_UNRELEASED.md
)Automatic note to reviewers
Read this Checklist and put a milestone if possible.