-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Itv #869
Itv #869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I have tried to use it in PR #873 and it seems to work as intended (in the sense that it seems to replace the prob
type that was used in PR #794). It is likely that we will be able to use it to port previous work on convexity.
About the contents of the PR, I have minor comments.
Class infer
, lemma inferP
, class unify
, unify'
, instance unify'P
already appear in signed.v
which is Require Imported, so maybe they can be removed (maybe they were duplicated to make the file self-contained?).
The identifiers top_typ_subproof
and top_typ
appear in both signed.v
and itv.v
, maybe they can be distinguished? (Similar comment for lemmas bottom
, gt0
, le0F
, lt0
, ge0F
, ge0
, lt0F
, le0
, gt0F
.)
Yes, since the hint and instances are
If we may import both (which seems likely), they indeed should be distinguished, maybe just prefix them with |
We could maybe issue about these two comments when merging:
|
* Add itv.v Taking inspiration on signed.v, replacing sign by intervals. * Add interval multiplication * Add hints to automatically solve _ <= 1 goals * Test to see if usable as a replacement for prob * use notation from mathcomp_extra.v * changelog and rm redundant code * prefix duplicated identifiers --------- Co-authored-by: Reynald Affeldt <[email protected]>
* Add itv.v Taking inspiration on signed.v, replacing sign by intervals. * Add interval multiplication * Add hints to automatically solve _ <= 1 goals * Test to see if usable as a replacement for prob * use notation from mathcomp_extra.v * changelog and rm redundant code * prefix duplicated identifiers --------- Co-authored-by: Reynald Affeldt <[email protected]>
work on Hoelder's inequality expeS, fin_numX (math-comp#829) \bar R canonicals for tblattice Co-authored-by: Quentin Vermande <[email protected]> Co-authored-by: Alessandro Bruni <[email protected]> Co-authored-by: Takafumi Saikawa <[email protected]> Co-authored-by: Reynald Affeldt <[email protected]> add lemma power12_sqrt fix and strengthen eq_bigmax and eq_bigmin (math-comp#863) Itv (math-comp#869) * Add itv.v Taking inspiration on signed.v, replacing sign by intervals. * Add interval multiplication * Add hints to automatically solve _ <= 1 goals * Test to see if usable as a replacement for prob * use notation from mathcomp_extra.v * changelog and rm redundant code * prefix duplicated identifiers --------- Co-authored-by: Reynald Affeldt <[email protected]> complete changelog fubini for s-finite measures (math-comp#877) fixes, cleaning powere_pos lemmas fixed `powere_pos` definition more lemmas for `powere_pos` progress in fixing hoelder wip powere_pos lemmas cleanup up wip wip
work on Hoelder's inequality expeS, fin_numX (math-comp#829) \bar R canonicals for tblattice Co-authored-by: Quentin Vermande <[email protected]> Co-authored-by: Alessandro Bruni <[email protected]> Co-authored-by: Takafumi Saikawa <[email protected]> Co-authored-by: Reynald Affeldt <[email protected]> add lemma power12_sqrt fix and strengthen eq_bigmax and eq_bigmin (math-comp#863) Itv (math-comp#869) * Add itv.v Taking inspiration on signed.v, replacing sign by intervals. * Add interval multiplication * Add hints to automatically solve _ <= 1 goals * Test to see if usable as a replacement for prob * use notation from mathcomp_extra.v * changelog and rm redundant code * prefix duplicated identifiers --------- Co-authored-by: Reynald Affeldt <[email protected]> complete changelog fubini for s-finite measures (math-comp#877) fixes, cleaning powere_pos lemmas fixed `powere_pos` definition more lemmas for `powere_pos` progress in fixing hoelder wip powere_pos lemmas cleanup up wip wip
Motivation for this change
I wanted to merge intervals with signed but clearly don't have time to pursue that path currently. Since it seems already useful as it is, let's PR it now, we could always try to improve later.
The multiplication only works for
realDomainType
(and not fornumDomainType
), for relatively bad reasons.The proof of the multiplication could probably be improved using
wlog
.Things done/to do
CHANGELOG_UNRELEASED.md
(do not edit former entries, only append new ones, be careful:
merge and rebase have a tendency to mess up
CHANGELOG_UNRELEASED.md
)Automatic note to reviewers
Read this Checklist and put a milestone if possible.