Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itv #869

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Itv #869

merged 7 commits into from
Mar 15, 2023

Conversation

proux01
Copy link
Collaborator

@proux01 proux01 commented Mar 4, 2023

Motivation for this change

I wanted to merge intervals with signed but clearly don't have time to pursue that path currently. Since it seems already useful as it is, let's PR it now, we could always try to improve later.

The multiplication only works for realDomainType (and not for numDomainType), for relatively bad reasons.
The proof of the multiplication could probably be improved using wlog.

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
    (do not edit former entries, only append new ones, be careful:
    merge and rebase have a tendency to mess up CHANGELOG_UNRELEASED.md)
  • added corresponding documentation in the headers
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist mentioned this pull request Mar 13, 2023
2 tasks
@affeldt-aist affeldt-aist added this to the 0.6.2 milestone Mar 14, 2023
@affeldt-aist affeldt-aist self-requested a review March 14, 2023 15:55
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I have tried to use it in PR #873 and it seems to work as intended (in the sense that it seems to replace the prob type that was used in PR #794). It is likely that we will be able to use it to port previous work on convexity.
About the contents of the PR, I have minor comments.
Class infer, lemma inferP, class unify, unify', instance unify'P already appear in signed.v which is Require Imported, so maybe they can be removed (maybe they were duplicated to make the file self-contained?).
The identifiers top_typ_subproof and top_typ appear in both signed.v and itv.v, maybe they can be distinguished? (Similar comment for lemmas bottom, gt0, le0F, lt0, ge0F, ge0, lt0F, le0, gt0F.)

@proux01
Copy link
Collaborator Author

proux01 commented Mar 14, 2023

Class infer, lemma inferP, class unify, unify', instance unify'P already appear in signed.v which is Require Imported, so maybe they can be removed (maybe they were duplicated to make the file self-contained?).

Yes, since the hint and instances are #[global], the Require Import is enough and they can be removed.

The identifiers top_typ_subproof and top_typ appear in both signed.v and itv.v, maybe they can be distinguished? (Similar comment for lemmas bottom, gt0, le0F, lt0, ge0F, ge0, lt0F, le0, gt0F.)

If we may import both (which seems likely), they indeed should be distinguished, maybe just prefix them with itv_?

@affeldt-aist affeldt-aist self-requested a review March 15, 2023 13:26
@affeldt-aist
Copy link
Member

We could maybe issue about these two comments when merging:

The multiplication only works for realDomainType (and not for numDomainType), for relatively bad reasons.
The proof of the multiplication could probably be improved using wlog.
And maybe also issue about the future removal of the trailing tests.

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Mar 15, 2023
@affeldt-aist affeldt-aist merged commit 36680bc into master Mar 15, 2023
@proux01 proux01 deleted the itv branch March 15, 2023 15:53
hoheinzollern pushed a commit to hoheinzollern/analysis that referenced this pull request Mar 24, 2023
* Add itv.v

Taking inspiration on signed.v, replacing sign by intervals.

* Add interval multiplication

* Add hints to automatically solve _ <= 1 goals

* Test to see if usable as a replacement for prob

* use notation from mathcomp_extra.v

* changelog and rm redundant code

* prefix duplicated identifiers

---------

Co-authored-by: Reynald Affeldt <[email protected]>
proux01 added a commit that referenced this pull request Mar 25, 2023
* Add itv.v

Taking inspiration on signed.v, replacing sign by intervals.

* Add interval multiplication

* Add hints to automatically solve _ <= 1 goals

* Test to see if usable as a replacement for prob

* use notation from mathcomp_extra.v

* changelog and rm redundant code

* prefix duplicated identifiers

---------

Co-authored-by: Reynald Affeldt <[email protected]>
hoheinzollern added a commit to hoheinzollern/analysis that referenced this pull request Apr 1, 2023
work on Hoelder's inequality

expeS, fin_numX (math-comp#829)
\bar R canonicals for tblattice

Co-authored-by: Quentin Vermande <[email protected]>

Co-authored-by: Alessandro Bruni <[email protected]>
Co-authored-by: Takafumi Saikawa <[email protected]>
Co-authored-by: Reynald Affeldt <[email protected]>

add lemma power12_sqrt

fix and strengthen eq_bigmax and eq_bigmin (math-comp#863)

Itv (math-comp#869)

* Add itv.v

Taking inspiration on signed.v, replacing sign by intervals.

* Add interval multiplication

* Add hints to automatically solve _ <= 1 goals

* Test to see if usable as a replacement for prob

* use notation from mathcomp_extra.v

* changelog and rm redundant code

* prefix duplicated identifiers

---------

Co-authored-by: Reynald Affeldt <[email protected]>

complete changelog

fubini for s-finite measures (math-comp#877)

fixes, cleaning

powere_pos lemmas

fixed `powere_pos` definition
more lemmas for `powere_pos`
progress in fixing hoelder

wip

powere_pos lemmas

cleanup

up

wip

wip
hoheinzollern added a commit to hoheinzollern/analysis that referenced this pull request Apr 13, 2023
work on Hoelder's inequality

expeS, fin_numX (math-comp#829)
\bar R canonicals for tblattice

Co-authored-by: Quentin Vermande <[email protected]>

Co-authored-by: Alessandro Bruni <[email protected]>
Co-authored-by: Takafumi Saikawa <[email protected]>
Co-authored-by: Reynald Affeldt <[email protected]>

add lemma power12_sqrt

fix and strengthen eq_bigmax and eq_bigmin (math-comp#863)

Itv (math-comp#869)

* Add itv.v

Taking inspiration on signed.v, replacing sign by intervals.

* Add interval multiplication

* Add hints to automatically solve _ <= 1 goals

* Test to see if usable as a replacement for prob

* use notation from mathcomp_extra.v

* changelog and rm redundant code

* prefix duplicated identifiers

---------

Co-authored-by: Reynald Affeldt <[email protected]>

complete changelog

fubini for s-finite measures (math-comp#877)

fixes, cleaning

powere_pos lemmas

fixed `powere_pos` definition
more lemmas for `powere_pos`
progress in fixing hoelder

wip

powere_pos lemmas

cleanup

up

wip

wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants