feat: funding #2251
feat: funding #2251
Conversation
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
|
To be honest, I'm not sure if we need to have a separate icon at all. I'm not so happy with both of your suggestions right now. |
PKief
force-pushed
the
main
branch
2 times, most recently
from
eeb4f0e to
b2e0fe4
Compare
|
We need this icons |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
|
Oh no... 🤦 And the icon with a heart is much more neutral, and means "developer support" and thanks for his work Btw., in the icon with a heart, you need to add some space around it |
|
@okineadev You're thinking that a hand with a coin automatically means that a developer is begging for alms? Personally, I don't see it that negative. When I google for "funding icon" the suggestions of Google are similar:
The heart icon doesn't really fit, because the file "funding.yml" is simply the configuration of the funding URLs - and not the action of sponsoring somebody. |
|
It still looks like a bum. If you think this is just a list of money transfer links. Then you can simply use the icon with a dollar or a penny |
That might be your opinion. From my point of view, one is not automatically a bum if you hold out your hand. I think the icon is very general and the recognition value of a file with this icon should be relatively high. |
|
Better cancel this PR. because it is a rather controversial icon |
|
Some may like her, and some may not. |
|
@okineadev the commit has been rolled back to avoid irritations. The Json or Yaml icon will be more neutral for that. There will be no funding icon at the moment. |
🫱🏿🫲🏻 |
* feat: update astro file icon and add astro folder icon * Remove plain black and white from allowed colors * feat: funding icon (#2251) * Add folder icons for Jupyter (#2368) * add folder icon for jupyter-notebooks * prevent recolor of the jupyter logo * Fit icon color to Material Design * Darker background for folder color of jupyter folder * replace logo colors by material color theme --------- Co-authored-by: Geronimo Bergk <[email protected]> * feat: update icons * Discard changes to src/icons/fileIcons.ts * Update folderIcons.ts * Remove funding icon (due to a backmerge which was already reverted) * update + add astro config icon --------- Signed-off-by: Florian Lefebvre <[email protected]> Co-authored-by: Philipp Kief <[email protected]> Co-authored-by: Bartłomiej Krakowski <[email protected]> Co-authored-by: Geronimo Bergk <[email protected]> Co-authored-by: Geronimo Bergk <[email protected]> Co-authored-by: Lucas Colombo <[email protected]>
No description provided.