feat(shape): Added Shape subsystem and integrated with all components #3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The previous contents of the mdc-shape package have been removed and replaced with mixins implementing the Shape system. This system implements only rounded corners to provide a straightforward CSS-only solution.
Codecov Report
@@ Coverage Diff @@
## master #3626 +/- ##
=========================================
Coverage ? 98.46%
=========================================
Files ? 120
Lines ? 5197
Branches ? 652
=========================================
Hits ? 5117
Misses ? 80
Partials ? 0Continue to review full report at Codecov.
|
abhiomkar
changed the title
abhiomkar
commented
Sep 24, 2018
.travis.yml
Outdated
| @@ -13,6 +13,7 @@ branches: | |||
| # This prevents excessive resource usage and CI slowness. | |||
| only: | |||
| - master | |||
| - feat/shape | |||
There was a problem hiding this comment.
TODO: Need to remove this line once all PRs are merged in feat/shape
kfranqueiro
reviewed
Sep 24, 2018
kfranqueiro
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3175 & #3176
BREAKING CHANGE: The previous contents of the mdc-shape package have been removed and replaced with mixins implementing the Shape system. This system implements only rounded corners to provide a straightforward CSS-only solution. Replaced all *-corner-radius component mixins with *-shape-radius mixins to integrate with Shape system.