-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename corner -> shape in tests #3622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/shape #3622 +/- ##
==============================================
- Coverage 98.43% 98.41% -0.03%
==============================================
Files 120 120
Lines 5192 5036 -156
Branches 649 620 -29
==============================================
- Hits 5111 4956 -155
+ Misses 81 80 -1
Continue to review full report at Codecov.
|
kfranqueiro
force-pushed
the
chore/shape-rename-tests
branch
from
September 24, 2018 15:36
7cae5f6
to
2a0e32f
Compare
abhiomkar
approved these changes
Sep 24, 2018
🤖 Beep boop! Screenshot test report 🚦21 screenshots changed from Details5 Changed:16 Added: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is based on #3552, so review after that's merged. (I'm running it against feat/shape so it runs screenshot tests.)