Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename corner -> shape in tests #3622

Merged
merged 5 commits into from
Sep 24, 2018
Merged

Conversation

kfranqueiro
Copy link
Contributor

Note: This is based on #3552, so review after that's merged. (I'm running it against feat/shape so it runs screenshot tests.)

@codecov-io
Copy link

codecov-io commented Sep 24, 2018

Codecov Report

Merging #3622 into feat/shape will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           feat/shape    #3622      +/-   ##
==============================================
- Coverage       98.43%   98.41%   -0.03%     
==============================================
  Files             120      120              
  Lines            5192     5036     -156     
  Branches          649      620      -29     
==============================================
- Hits             5111     4956     -155     
+ Misses             81       80       -1
Impacted Files Coverage Δ
packages/mdc-list/foundation.js 99.12% <0%> (-0.06%) ⬇️
packages/mdc-textfield/foundation.js 98.93% <0%> (-0.05%) ⬇️
packages/mdc-list/index.js 100% <0%> (ø) ⬆️
packages/mdc-menu/foundation.js 100% <0%> (ø) ⬆️
packages/mdc-ripple/foundation.js 100% <0%> (ø) ⬆️
packages/mdc-menu/index.js 100% <0%> (ø) ⬆️
packages/mdc-dialog/constants.js 100% <0%> (ø) ⬆️
packages/mdc-dialog/foundation.js 100% <0%> (ø) ⬆️
packages/mdc-dom/ponyfill.js 100% <0%> (ø) ⬆️
packages/mdc-dialog/index.js 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40fe2c...cbbcb27. Read the comment docs.

@kfranqueiro kfranqueiro changed the base branch from master to feat/shape September 24, 2018 15:32
@kfranqueiro kfranqueiro merged commit 5d2679b into feat/shape Sep 24, 2018
@kfranqueiro kfranqueiro deleted the chore/shape-rename-tests branch September 24, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants