fix(switch): Remove checkbox references from SCSS #352
Conversation
| @@ -725,6 +725,10 @@ Concretely: | |||
| contains javascript, ensure that its component namespace is exported within | |||
| `material-components-web`, and it is registered with `mdc-auto-init`. Lastly, remember to add it | |||
| to `package.json` of `material-components-web`. | |||
| - Ensure that the correct **commit subject** for the package is added to the | |||
There was a problem hiding this comment.
Do you mean if this package is added to config.validate-commit-msg.scope.allowed then its commit message will be checked and if I wrote wrong commit message like "feat(mdc-grid-list): Implement mdc-grid-list (#47)" it won't go through?
What about cases if I forget to add this package to that config file, will that commit message go through? As far as what I am concerning, this should be an 'opt-out' instead 'opt-in' check.
There was a problem hiding this comment.
Do you mean if this package is added to config.validate-commit-msg.scope.allowed then its commit message will be checked and if I wrote wrong commit message like "feat(mdc-grid-list): Implement mdc-grid-list (#47)" it won't go through?
That's correct!
What about cases if I forget to add this package to that config file, will that commit message go through?
It won't. So this ensures that either you:
- Use a pre-defined scope
- Add the new component scope to the config
yeelan0319
dismissed
their stale review
It should be a general comment not a request review
|
Approved! |
|
SGTM I included it in here since it doesn't really break anything. Also I'm going to update the list to include |
- Remove all references to mdc-checkbox in mdc-theme-dark mixin - Add `mdc-switch-transition` function and replace calls to `mdc-checkbox-transition` with that function - (techdebt) Update cross-env and cz-conventional-changelog - (techdebt) Add allowed scopes to validate-commit-msg config, and docs on how to add new scopes when a component is added. Fixes #322
traviskaufman
force-pushed
the
fix/rm-implicit-checkbox-sass-from-switch
branch
from
362b47f
to
9f08315
Compare
mdc-switch-transitionfunction and replace calls tomdc-checkbox-transitionwith that functionon how to add new scopes when a component is added.
Fixes #322