Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect use of mdc-checkbox-* references within mdc-switch SCSS #322

Closed
traviskaufman opened this issue Feb 21, 2017 · 0 comments
Closed

Incorrect use of mdc-checkbox-* references within mdc-switch SCSS #322

traviskaufman opened this issue Feb 21, 2017 · 0 comments
Assignees
@amsheehan
Labels
backlog bug

Comments

@traviskaufman
Copy link
Contributor

Within mdc-switch code, there are implicit references made to mdc-checkbox, in two places:

  • @include mdc-theme-dark(".mdc-checkbox") is used instead of @include mdc-theme-dark(".mdc-switch") (example).

  • @include mdc-checkbox-transition is used instead of a mdc-switch-transition mixin that should be defined (example).

This hasn't bitten us I think, because mdc-checkbox et. al. is included within the sass compilation context when we bundle our assets via webpack. However, if someone were to try and bundle our sass manually, it would fail. Furthermore, I don't think mdc-switch--theme-dark would work properly if attached to the mdc-switch element.

I personally think we should maybe prioritize fixing this for this sprint cc @amsheehan
@amsheehan amsheehan self-assigned this Feb 22, 2017
traviskaufman added a commit that referenced this issue Feb 23, 2017
@traviskaufman
fix(switch): Remove checkbox references from SCSS
dee0b7b 
- Remove all references to mdc-checkbox in mdc-theme-dark mixin
- Add `mdc-switch-transition` function and replace calls to
  `mdc-checkbox-transition` with that function
- (techdebt) Update cross-env and cz-conventional-changelog
- (techdebt) Add allowed scopes to validate-commit-msg config, and docs
  on how to add new scopes when a component is added.

Fixes #322
traviskaufman added a commit that referenced this issue Feb 23, 2017
@traviskaufman
fix(switch): Remove checkbox references from SCSS
362b47f 
- Remove all references to mdc-checkbox in mdc-theme-dark mixin
- Add `mdc-switch-transition` function and replace calls to
  `mdc-checkbox-transition` with that function
- (techdebt) Update cross-env and cz-conventional-changelog
- (techdebt) Add allowed scopes to validate-commit-msg config, and docs
  on how to add new scopes when a component is added.

Fixes #322
@traviskaufman traviskaufman mentioned this issue Feb 23, 2017
Merged
traviskaufman added a commit that referenced this issue Feb 27, 2017
@traviskaufman
fix(switch): Remove checkbox references from SCSS
9f08315 
- Remove all references to mdc-checkbox in mdc-theme-dark mixin
- Add `mdc-switch-transition` function and replace calls to
  `mdc-checkbox-transition` with that function
- (techdebt) Update cross-env and cz-conventional-changelog
- (techdebt) Add allowed scopes to validate-commit-msg config, and docs
  on how to add new scopes when a component is added.

Fixes #322
traviskaufman added a commit that referenced this issue Feb 27, 2017
@traviskaufman
fix(switch): Remove checkbox references from SCSS (#352)
ac88267 
- Remove all references to mdc-checkbox in mdc-theme-dark mixin
- Add `mdc-switch-transition` function and replace calls to
  `mdc-checkbox-transition` with that function
- (techdebt) Update cross-env and cz-conventional-changelog
- (techdebt) Add allowed scopes to validate-commit-msg config, and docs
  on how to add new scopes when a component is added.

Fixes #322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amsheehan amsheehan

Labels
backlog bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@traviskaufman @amsheehan