Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove abstract function bodies in closure rewriting #2610

Merged
merged 3 commits into from
Apr 23, 2018
Merged

chore: Remove abstract function bodies in closure rewriting #2610

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1b8197
chore: Remove abstract function bodies in closure rewriting
Apr 20, 2018
fa4a873
Merge branch 'master' into chore/rewrite-hollow-abstract
kfranqueiro Apr 23, 2018
07423bf
WIP Fix lint
Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions scripts/rewrite-decl-statements-for-closure-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,14 @@ function transform(srcFile, rootDir) {
}
path.replaceWith(variableDeclaration);
},

ClassMethod(path) {
// Remove any statements from abstract function bodies.
// Closure doesn't like seeing this, but we like to include a throw statement for non-closure clients.
if (path.node.comments && path.node.comments.some((comment) => comment.value.includes('@abstract'))) {
path.node.body.body = [];
}
},
});

let {code: outputCode} = recast.print(ast, {
Expand Down