Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slider): reduce scss specificity #2158

Closed
wants to merge 4 commits into from
Closed

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Feb 1, 2018

related: #1687

@codecov-io
Copy link

codecov-io commented Feb 1, 2018

Codecov Report

Merging #2158 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2158   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          84       84           
  Lines        3768     3768           
  Branches      489      489           
=======================================
  Hits         3740     3740           
  Misses         28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01bb84...bb1f27f. Read the comment docs.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are moving mixin invocations which rely on & to an @at-root selector, which means the & is now nothing. e.g. .mdc-slider:not(.mdc-slider--disabled) .mdc-slider__track becomes just :not(.mdc-slider--disabled) .mdc-slider__track which will apply to every MDC Slider instance because :not(...) will match any parent of the slider track whatsoever.

This change is not safe to make and I think we should close this PR.

@kfranqueiro
Copy link
Contributor

Confirmed, this breaks disabled styles.

What it should look like:

image

What it looks like in this PR:

image

Closing this, since the only change this makes causes a regression.

@kfranqueiro kfranqueiro closed this Feb 5, 2018
@moog16 moog16 deleted the chore/slider/bem-audit branch February 5, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants