-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(slider): reduce scss specificity #2158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2158 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 84 84
Lines 3768 3768
Branches 489 489
=======================================
Hits 3740 3740
Misses 28 28 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are moving mixin invocations which rely on &
to an @at-root
selector, which means the &
is now nothing. e.g. .mdc-slider:not(.mdc-slider--disabled) .mdc-slider__track
becomes just :not(.mdc-slider--disabled) .mdc-slider__track
which will apply to every MDC Slider instance because :not(...)
will match any parent of the slider track whatsoever.
This change is not safe to make and I think we should close this PR.
related: #1687