-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect BEM when outputting the base stylesheet #1687
Labels
Comments
amsheehan
changed the title
SCSS files in the
SCSS files in the demos folder specify MDC Web's name space in the selectors.
Dec 4, 2017
demo/
folder specify MDC Web's name space in the selectors.
To the first point, yes we should be using only the demo selector in CSS. |
See #1733 for an example on how to fix the Sass mixins and demo pages. This PR is for checkbox only |
This was referenced Dec 14, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
lynnmercier
changed the title
SCSS files in the demos folder specify MDC Web's name space in the selectors.
Respect BEM when outputting the base stylesheet
Jan 23, 2018
This was referenced Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Previously, I believe the specificity was warranted because of some other demo pages outside of the MDC Web catalog page. Since this is no longer the case, I think we should change it back to the demo selector.
Instead of
.mdc-radio.demo-radio--custom {}
, use.demo-radio--custom {}
Also if we're trying to use BEM here, we are using it incorrectly. For there to be a modifier class, we need a block or element to modify.
For instance, in
demos/radio.html
we have elements with:class="mdc-radio demo-radio--custom"
This should read:
class="mdc-radio demo-radio demo-radio--custom"
to adhere to BEM style.The text was updated successfully, but these errors were encountered: