Addresses 3 issues #1053
Addresses 3 issues #1053
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
==========================================
- Coverage 99.93% 99.78% -0.16%
==========================================
Files 68 68
Lines 3274 3284 +10
Branches 403 404 +1
==========================================
+ Hits 3272 3277 +5
- Misses 2 7 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks for cleaning up our READMEs! Lets get these es2015 import fixes in first.
Please move the Textfield.valid code to another PR. I tried to highlight the files/lines of code you need to move.
And lets talk more about labels across disabled switches, radio buttons, and checkboxes more before we get a PR out.
Thanks for fixing three things at once 😄 , it is just hard for my weary brain to review 12 files at once 😩 .
packages/mdc-switch/mdc-switch.scss
Outdated
| @@ -192,3 +193,11 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| .mdc-switch-label { | |||
There was a problem hiding this comment.
Take this out of this PR. I want to discuss more if we want one mdc-label for switch, checkbox, and radio...or if we need three classes.
packages/mdc-textfield/README.md
Outdated
| An input's validity is checked via `checkValidity()` on blur, and the styles are updated | ||
| accordingly. When using the `required` attribute, an asterisk will be automatically appended to the | ||
| label text, as per the spec. | ||
| By default an input's validity is checked via `checkValidity()` on blur, and the styles are updated |
There was a problem hiding this comment.
Move this Textfield.valid out to another PR
packages/mdc-textfield/README.md
Outdated
| @@ -324,6 +324,10 @@ with the corresponding id within the document and automatically assign it to thi | |||
| Boolean. Proxies to the foundation's `isDisabled/setDisabled` methods when retrieved/set | |||
| respectively. | |||
|
|
|||
| ##### MDCTextfield.valid | |||
There was a problem hiding this comment.
Move out to Textfield.valid PR
packages/mdc-textfield/foundation.js
Outdated
| @@ -57,6 +57,7 @@ export default class MDCTextfieldFoundation extends MDCFoundation { | |||
| this.inputBlurHandler_ = () => this.deactivateFocus_(); | |||
| this.inputInputHandler_ = () => this.autoCompleteFocus_(); | |||
| this.inputKeydownHandler_ = () => this.receivedUserInput_ = true; | |||
| this.useNativeValidityChecking_ = true; | |||
There was a problem hiding this comment.
Move this entire file out to Textfield.valid PR
|
I split the 3 issues across 3 branches in my fork and i closed this one. |
#999 - Partially completed (I need answers)
#1018 - Added new feature to MDCTextfield
#1049 - Updated READMEs to fix es2015 imports
Sorry for referencing 3 issues in 1 PR.