-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the README for the switch package #999
Comments
The class mdc-switch-label on the label doesn't do anything either |
You are correct. Looks like an incomplete implementation to me. The label definitely should do something when a I'm wondering if you'd like to submit a pull request to fix this oversight. Changes would be:
If you have questions about specific implementations for the other components feel free to ask. If you don't have the cycles let us know. Thanks! |
@amsheehan Ok so, regarding the checkbox and the radio, they don't have classes for labels (something like mdc-checkbox-label) and I was wondering if it would be better to remove the mdc-switch-label class for simplicity and consistency rather than adding the 2 extra classes for the labels. |
The label could be handled by form-field, just like for checkbox and radio. https://material.io/components/web/catalog/input-controls/form-fields/ |
@dessant the sass file for the form-field package doesn't contain any label styling besides rtl/dark-theme, |
@teoxoy I kinda like the idea of having the same class for labels on checkbox, radio, and switch...but we need to check with designers to see if these three components are similar enough. I don't want to couple code together and end up overriding all the time. But my guess is that since all three are Selection Controls, they might be similar enough. |
I'm going to split this into two issues
We'd like to keep styling of labels in sync between checkbox, radio, and switch with mdc-form-field |
The Modifier mdc-switch--disabled specified at the end of the README doesn't do anything. I looked trough the sass file and there is no mention of any class called mdc-switch--disabled.
The text was updated successfully, but these errors were encountered: