feat(menu): add component #786

moog16 · 2019-03-29T00:06:45Z

Updating enzyme since context API is not supported by older version. See enzymejs/enzyme#1553

googlebot · 2019-03-29T00:06:50Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

codecov-io · 2019-03-29T00:06:52Z

Codecov Report

Merging #786 into rc0.12.0 will decrease coverage by 0.84%.
The diff coverage is 82.35%.

@@             Coverage Diff              @@
##           rc0.12.0     #786      +/-   ##
============================================
- Coverage     95.14%   94.29%   -0.85%     
============================================
  Files            73       73              
  Lines          2924     2964      +40     
  Branches        449      459      +10     
============================================
+ Hits           2782     2795      +13     
- Misses           46       61      +15     
- Partials         96      108      +12

Impacted Files	Coverage Δ
packages/tab/TabRipple.tsx	`100% <ø> (ø)`	⬆️
packages/checkbox/index.tsx	`89.47% <100%> (+0.14%)`	⬆️
packages/snackbar/index.tsx	`95.65% <100%> (ø)`	⬆️
packages/chips/ChipSet.tsx	`98.79% <100%> (ø)`	⬆️
packages/drawer/index.tsx	`93.91% <100%> (ø)`	⬆️
packages/switch/index.tsx	`100% <100%> (ø)`	⬆️
packages/list/ListItem.tsx	`100% <100%> (+2.12%)`	⬆️
packages/tab-bar/index.tsx	`83.87% <50%> (-1.85%)`	⬇️
packages/chips/Chip.tsx	`92.38% <58.82%> (-5.6%)`	⬇️
packages/tab/index.tsx	`95.83% <66.66%> (-3.08%)`	⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd7776...aafb2d1. Read the comment docs.

codecov-io · 2019-03-29T00:06:53Z

Codecov Report

Merging #786 into feat/mdcweb-typescript-update will increase coverage by 0.31%.
The diff coverage is 96.29%.

@@                        Coverage Diff                        @@
##           feat/mdcweb-typescript-update     #786      +/-   ##
=================================================================
+ Coverage                           93.9%   94.22%   +0.31%     
=================================================================
  Files                                 73       76       +3     
  Lines                               3021     3185     +164     
  Branches                             461      478      +17     
=================================================================
+ Hits                                2837     3001     +164     
  Misses                                65       65              
  Partials                             119      119

Impacted Files	Coverage Δ
packages/menu-surface/index.tsx	`83.64% <ø> (ø)`	⬆️
packages/menu/MenuList.tsx	`100% <100%> (ø)`
packages/menu/MenuListItem.tsx	`100% <100%> (ø)`
packages/menu/index.tsx	`92.85% <92.85%> (ø)`
packages/list/index.tsx	`94.28% <95.45%> (+2.24%)`	⬆️
packages/list/ListItem.tsx	`98.91% <98.43%> (-1.09%)`	⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14202c...f93bcdf. Read the comment docs.

googlebot · 2019-03-29T01:30:58Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

lucasecdb · 2019-03-30T13:32:15Z

packages/menu/index.tsx

+  }
+
+  get listElements(): Element[] {
+    if (!(this.menuListElement


you don't need to check for this.menuListElement

lucasecdb · 2019-03-30T13:33:18Z

packages/menu/MenuListItem.tsx

+  children?: React.ReactNode;
+}
+
+class MenuListItem<T extends HTMLElement = HTMLElement> extends React.Component<MenuListItemProps<T>, {}> {


this could be a functional component

I actually need this to be a Compnonent to pass along the defaultProps. Any idea around that?

yeah, I don't think we could reuse the default props from the list item :-/

The defaultProp is the renderWithListItemProps, so it can't live on the listItem. Is that what you are suggesting?

no, my idea would be to use default parameters on the function (which is the recommended way to use default props on function component) like this

const MenuListItem = <T extends HTMLElement = HTMLElement>({ renderWithListItemProps = true, ...props }) => { // etc }

but then we would need to redeclare every prop on the defaultProps of the ListItem. does that make sense?

ah ya - of course I need to pass that along...however, I don't think we need to pass the same defaultProps to the ListItem...The reason I have renderWithListItemProps on the MenuListItem, is so that the List knows to pass along certain props to the MenuListItem. Does that make sense?

oh, I see. I think that's kind a weird way to do it 😄

can't you add to the check of element.type === ListItem the MenuListItem?

Ya I realize that's weird...but it also seemed wierd that MenuListItem is referenced in List. What do you think?

I guess that is the better more foolproof way :| -- I'll wait to hear back from you if you think of something better.

you can create a context in the List component and use the context consumer in both ListItem and MenuListItem, and in the context you can put the functions you need in the item. What do you think?

lucasecdb · 2019-03-30T13:43:11Z

packages/menu/index.tsx

+
+export interface MenuProps extends Exclude<MenuSurfaceProps, 'ref'> {
+  children: React.ReactElement<MenuList>;
+  handleSelected?: (index: number, item: Element) => void;


shouldn't the prop name be onSelected? just like onChange for an input element

Ya that makes sense. However we use the word handle in a few other places. We should normalize that to on at some point.

…ent_try3

…ntext

…ent_try3

…_try3

moog16 · 2019-04-05T17:27:59Z

packages/list/ListItem.tsx

+    return this.listElements.indexOf(listElement);
+  }
+
+  handleClick = (e: React.MouseEvent<any>) => {


These are moved from list/index.tsx

…ent_try3

lucasecdb · 2019-04-19T19:10:44Z

packages/list/index.tsx

+
+  listItemProps = {
+    checkboxList: this.props.checkboxList,
+    radioList: this.props.radioList,


this won't work for when the user changes these props, right? I think it would be better to place this in some method and use a memoization helper to avoid creating this object on every render

highly recommended reading this article if you haven't yet :-)

ah right - this won't be updated. Is this object created every render? Does that article go over it? I thought having it on the class would make sure its the same object every render.

no, the object itself is only created once, but in order to update the props with the user, it should be at least created once per user change. does that make sense?

btw is there an ETA for 0.12? I really wanted this component 😢

Yup that makes sense. I actually just read that article and it had some great points. Although it made me kinda sad since we follow a lot of the patterns that Dan suggested NOT to do...I think we're aware of them, as others have opened issues against some of these patterns. So we'll have to revisit a lot of these components moving forward.

RE listItemProps: Yes you're right. I think we can use the react.memo like you're saying, and recalculate this in the render.

RE ETA: No official ETA. The rate at which we're going, I don't see a release next week. So I'll update to the Tuesday after 4/30. How does that sound?

~~4/30 sounds good!~~ actually, it's the next week, right? haha. but that's fine for me too

about the anti-patterns, we could compile a list of them and open an issue with a checklist, so it's easier to see which ones are missing the update. I would definitely help address them.

4/30 is 7 business days...so about 1.5weeks. @TroyTae can you also agree to this date? We can push character count to another release.

Ya definitely... I will compile a list and add it as an issue / let you know.

@moog16
Sorry late response.
I was planning to work on character count in last weekend.
But I had a sick, so I couldn't do nothing.
If you do not mind I want to push back count character release for stable.

No need to apologize. That sounds good to me.

Created an issue: #817

lucasecdb · 2019-04-20T02:38:55Z

packages/list/index.tsx

@@ -394,6 +384,23 @@ export default class List extends React.Component<ListProps, ListState> {
      tag: Tag,
      ...otherProps
    } = this.props;
+
+    const getListProps = (checkboxList?: boolean, radioList?: boolean) => ({


I think this needs to be a class property, just like before. Defining this on render every time will reset the memoize-one cache 😔

ah! Thanks for catching that. I will update. Been working on the select. But will get back to this.

lucasecdb · 2019-04-23T01:59:44Z

packages/list/index.tsx

@@ -364,6 +364,19 @@ export default class List extends React.Component<ListProps, ListState> {
    this.setState({listItemClassNames});
  };

+
+  getListProps = (checkboxList?: boolean, radioList?: boolean) => ({


I believe you should place the call to memoizeOne directly here. If it's in render, the cache will still be reseted.

(sorry for commenting so much 😅)

I think my last comment wasn't clear enough, sorry

I believe you're right again sir!

(please keep the comments coming)

moog16 · 2019-04-23T20:37:32Z

Tests are not passing because of esModuleInterop: false. #818 updates this to true. Tests should pass after this is merged.

…ent_try3

moog16 · 2019-04-26T17:23:50Z

I've been running into this issue enzymejs/enzyme#2108. Added a postinstall script to hopefully fix it.

williamernest · 2019-04-26T21:09:50Z

packages/list/ListItem.tsx

@@ -54,15 +54,54 @@ export default class ListItem<T extends HTMLElement = HTMLElement> extends React
    onBlur: () => {},
    onDestroy: () => {},
    tag: 'li',
+    handleClick: () => {},


The naming here seems inconsistent. You're using onBlur and handleClick. I recommend being consistent with your event handler names (and generally prefer on{EventName})

onClick is a native React click handler. I don't want to collide and override this behavior since its native to React. Therefore I must use a different name (handleClick) so that I don't collide with the naming.

williamernest · 2019-04-26T21:12:03Z

packages/list/ListItem.tsx

@@ -90,21 +165,51 @@ export default class ListItem<T extends HTMLElement = HTMLElement> extends React
      checkboxList,
      radioList,
      onDestroy,
+      onClick,


I'm confused, what is the difference between onClick and handleClick ?

see https://github.com/material-components/material-components-web-react/pull/786/files/f93bcdf660f50ff5a4ce61e65287b25520df2d1c#r279107245

commit 14b22bc Author: Matt Goo <[email protected]> Date: Tue Apr 30 12:06:32 2019 -0700 feat(select): enhanced select (#823) commit b400013 Author: Matt Goo <[email protected]> Date: Mon Apr 29 14:49:32 2019 -0700 chore: reduce unused deps in package.json (#819) commit beedb23 Author: Matt Goo <[email protected]> Date: Mon Apr 29 13:43:20 2019 -0700 feat(select): add icon (#825) commit e22ac2a Author: Matt Goo <[email protected]> Date: Mon Apr 29 13:35:45 2019 -0700 feat(select): add helper text (#824) commit abaa146 Author: Matt Goo <[email protected]> Date: Mon Apr 29 13:35:16 2019 -0700 feat(select): add option component (#826) commit 7adc12a Author: Matt Goo <[email protected]> Date: Mon Apr 29 13:11:16 2019 -0700 fix(drawer): add missing foundation import in drawer (#821) commit 7e0f877 Author: Matt Goo <[email protected]> Date: Fri Apr 26 14:33:40 2019 -0700 feat(menu): add component (#786) commit 509e93e Author: Matt Goo <[email protected]> Date: Fri Apr 26 09:46:26 2019 -0700 chore(infrastructure): add esmoduleinterop to tsconfig (#818) commit 4dbc8b8 Author: Matt Goo <[email protected]> Date: Tue Apr 16 15:56:25 2019 -0700 feat(notched-outline): update to v1.1.1 (#806) commit ea15a2a Author: 태재영 <[email protected]> Date: Sat Apr 13 06:50:37 2019 +0900 fix(chips): Fix incorrect ripple effect (#804) commit 7b413df Author: Matt Goo <[email protected]> Date: Mon Apr 8 13:27:36 2019 -0700 feat(button): update mdc web deps to v1.1.0 (#791) commit 034158c Author: Matt Goo <[email protected]> Date: Tue Apr 2 17:36:46 2019 -0700 fix: remove .only (#794) commit 74379af Author: Matt Goo <[email protected]> Date: Tue Apr 2 16:24:45 2019 -0700 fix(list): maintain classes with state.listItemClassNames (#776) BREAKING CHANGE: Removes props.tabbableOnListItemFocus from all the auxiliary components, as it seemed confusing to have this and tabIndex dictate what tabIndex would ultimately be. commit e5b953f Author: Ben McKernan <[email protected]> Date: Tue Apr 2 20:18:03 2019 +0200 fix(icon-button): upgrade to mdc-web v1.1 (#792) commit 9c7bfa7 Author: Andrii Kostenko <[email protected]> Date: Mon Apr 1 23:08:27 2019 +0300 fix(card): upgrade to mdc-web v1.1 (#788) commit bb9e7e4 Author: Andrii Kostenko <[email protected]> Date: Mon Apr 1 20:44:28 2019 +0300 fix(top-app-bar): mdc-web v1 upgrade (#780) commit 37c7269 Author: Andrii Kostenko <[email protected]> Date: Mon Apr 1 20:00:39 2019 +0300 fix(linear-progress): upgrade mdc-web to v1 (#787) commit b6403e6 Author: Andrii Kostenko <[email protected]> Date: Mon Apr 1 19:38:31 2019 +0300 fix(fab): upgrade to mdc-web v1.1 (#790) commit bcda111 Author: Andrii Kostenko <[email protected]> Date: Fri Mar 29 21:11:19 2019 +0300 fix(dialog): mdc-web v1 upgrade (#779) commit 8ff8695 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 28 22:32:55 2019 +0300 fix(typography): upgrade to mdc-web v1 (#778) commit 4d6bbc0 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 28 22:15:22 2019 +0300 feat(radio): upgrade to typescript v1 (#777) commit 4f523e3 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 28 22:13:29 2019 +0300 fix(checkbox): upgrade mdc-web to v1 (#769) commit 1a04f3d Author: Matt Goo <[email protected]> Date: Wed Mar 27 12:39:00 2019 -0700 feat(menu-surface): upgrade to mdc web v1 (#774) commit 44cca84 Author: Andrii Kostenko <[email protected]> Date: Wed Mar 27 01:14:18 2019 +0200 feat(switch): upgrade to mdc-web v1 (#757) commit 580c850 Author: Andrii Kostenko <[email protected]> Date: Wed Mar 27 01:13:37 2019 +0200 fix(tab-bar): upgrade mdc-web to v1 (#770) commit 45fef89 Author: Matt Goo <[email protected]> Date: Mon Mar 25 15:27:29 2019 -0700 fix(card): add react-ripple to package json (#773) commit 4e99b4c Author: Matt Goo <[email protected]> Date: Tue Mar 19 14:10:37 2019 -0700 feat(list): update to MDC Web 1.0.0 (#740) commit 38e9886 Author: Matt Goo <[email protected]> Date: Tue Mar 19 12:36:06 2019 -0700 feat(floating-label): update mdc web to v1.0.0 (#741) commit dd95b60 Author: Andrii Kostenko <[email protected]> Date: Mon Mar 18 23:38:34 2019 +0200 feat(snackbar): MDC Web v1.0.0 (#755) commit 9b86474 Author: Andrii Kostenko <[email protected]> Date: Mon Mar 18 23:27:39 2019 +0200 fix(tab): mdc-web v1.0.0 upgrade (#748) commit a8c64b5 Author: Lucas Cordeiro <[email protected]> Date: Mon Mar 18 17:46:29 2019 -0300 feat(drawer): add innerRef prop (#749) commit 5f55983 Author: Andrii Kostenko <[email protected]> Date: Fri Mar 15 19:05:44 2019 +0200 fix(chips): upgrade mdc-web to v1.0.0 (#750) commit 09cb8a5 Author: Matt Goo <[email protected]> Date: Fri Mar 15 10:05:03 2019 -0700 fix: [email protected] --> [email protected] & update imports (#709) commit ae9b421 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 14 20:53:28 2019 +0300 fix(tab-scroller): upgrade mdc-web to 1.0.0 (#743) commit 1b29dd9 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 14 20:32:18 2019 +0300 fix(tab-indicator): upgrade mdc-web to 1.0.0 (#742) commit f966714 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 14 19:45:11 2019 +0300 feat(ripple) mdc-web typescript conversion (#711) commit 0b674f5 Author: Andrii Kostenko <[email protected]> Date: Fri Mar 8 23:54:24 2019 +0300 feat(line-ripple): mdc-web typescript support (#716)

* Squashed commit of the following: commit 14b22bc Author: Matt Goo <[email protected]> Date: Tue Apr 30 12:06:32 2019 -0700 feat(select): enhanced select (#823) commit b400013 Author: Matt Goo <[email protected]> Date: Mon Apr 29 14:49:32 2019 -0700 chore: reduce unused deps in package.json (#819) commit beedb23 Author: Matt Goo <[email protected]> Date: Mon Apr 29 13:43:20 2019 -0700 feat(select): add icon (#825) commit e22ac2a Author: Matt Goo <[email protected]> Date: Mon Apr 29 13:35:45 2019 -0700 feat(select): add helper text (#824) commit abaa146 Author: Matt Goo <[email protected]> Date: Mon Apr 29 13:35:16 2019 -0700 feat(select): add option component (#826) commit 7adc12a Author: Matt Goo <[email protected]> Date: Mon Apr 29 13:11:16 2019 -0700 fix(drawer): add missing foundation import in drawer (#821) commit 7e0f877 Author: Matt Goo <[email protected]> Date: Fri Apr 26 14:33:40 2019 -0700 feat(menu): add component (#786) commit 509e93e Author: Matt Goo <[email protected]> Date: Fri Apr 26 09:46:26 2019 -0700 chore(infrastructure): add esmoduleinterop to tsconfig (#818) commit 4dbc8b8 Author: Matt Goo <[email protected]> Date: Tue Apr 16 15:56:25 2019 -0700 feat(notched-outline): update to v1.1.1 (#806) commit ea15a2a Author: 태재영 <[email protected]> Date: Sat Apr 13 06:50:37 2019 +0900 fix(chips): Fix incorrect ripple effect (#804) commit 7b413df Author: Matt Goo <[email protected]> Date: Mon Apr 8 13:27:36 2019 -0700 feat(button): update mdc web deps to v1.1.0 (#791) commit 034158c Author: Matt Goo <[email protected]> Date: Tue Apr 2 17:36:46 2019 -0700 fix: remove .only (#794) commit 74379af Author: Matt Goo <[email protected]> Date: Tue Apr 2 16:24:45 2019 -0700 fix(list): maintain classes with state.listItemClassNames (#776) BREAKING CHANGE: Removes props.tabbableOnListItemFocus from all the auxiliary components, as it seemed confusing to have this and tabIndex dictate what tabIndex would ultimately be. commit e5b953f Author: Ben McKernan <[email protected]> Date: Tue Apr 2 20:18:03 2019 +0200 fix(icon-button): upgrade to mdc-web v1.1 (#792) commit 9c7bfa7 Author: Andrii Kostenko <[email protected]> Date: Mon Apr 1 23:08:27 2019 +0300 fix(card): upgrade to mdc-web v1.1 (#788) commit bb9e7e4 Author: Andrii Kostenko <[email protected]> Date: Mon Apr 1 20:44:28 2019 +0300 fix(top-app-bar): mdc-web v1 upgrade (#780) commit 37c7269 Author: Andrii Kostenko <[email protected]> Date: Mon Apr 1 20:00:39 2019 +0300 fix(linear-progress): upgrade mdc-web to v1 (#787) commit b6403e6 Author: Andrii Kostenko <[email protected]> Date: Mon Apr 1 19:38:31 2019 +0300 fix(fab): upgrade to mdc-web v1.1 (#790) commit bcda111 Author: Andrii Kostenko <[email protected]> Date: Fri Mar 29 21:11:19 2019 +0300 fix(dialog): mdc-web v1 upgrade (#779) commit 8ff8695 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 28 22:32:55 2019 +0300 fix(typography): upgrade to mdc-web v1 (#778) commit 4d6bbc0 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 28 22:15:22 2019 +0300 feat(radio): upgrade to typescript v1 (#777) commit 4f523e3 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 28 22:13:29 2019 +0300 fix(checkbox): upgrade mdc-web to v1 (#769) commit 1a04f3d Author: Matt Goo <[email protected]> Date: Wed Mar 27 12:39:00 2019 -0700 feat(menu-surface): upgrade to mdc web v1 (#774) commit 44cca84 Author: Andrii Kostenko <[email protected]> Date: Wed Mar 27 01:14:18 2019 +0200 feat(switch): upgrade to mdc-web v1 (#757) commit 580c850 Author: Andrii Kostenko <[email protected]> Date: Wed Mar 27 01:13:37 2019 +0200 fix(tab-bar): upgrade mdc-web to v1 (#770) commit 45fef89 Author: Matt Goo <[email protected]> Date: Mon Mar 25 15:27:29 2019 -0700 fix(card): add react-ripple to package json (#773) commit 4e99b4c Author: Matt Goo <[email protected]> Date: Tue Mar 19 14:10:37 2019 -0700 feat(list): update to MDC Web 1.0.0 (#740) commit 38e9886 Author: Matt Goo <[email protected]> Date: Tue Mar 19 12:36:06 2019 -0700 feat(floating-label): update mdc web to v1.0.0 (#741) commit dd95b60 Author: Andrii Kostenko <[email protected]> Date: Mon Mar 18 23:38:34 2019 +0200 feat(snackbar): MDC Web v1.0.0 (#755) commit 9b86474 Author: Andrii Kostenko <[email protected]> Date: Mon Mar 18 23:27:39 2019 +0200 fix(tab): mdc-web v1.0.0 upgrade (#748) commit a8c64b5 Author: Lucas Cordeiro <[email protected]> Date: Mon Mar 18 17:46:29 2019 -0300 feat(drawer): add innerRef prop (#749) commit 5f55983 Author: Andrii Kostenko <[email protected]> Date: Fri Mar 15 19:05:44 2019 +0200 fix(chips): upgrade mdc-web to v1.0.0 (#750) commit 09cb8a5 Author: Matt Goo <[email protected]> Date: Fri Mar 15 10:05:03 2019 -0700 fix: [email protected] --> [email protected] & update imports (#709) commit ae9b421 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 14 20:53:28 2019 +0300 fix(tab-scroller): upgrade mdc-web to 1.0.0 (#743) commit 1b29dd9 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 14 20:32:18 2019 +0300 fix(tab-indicator): upgrade mdc-web to 1.0.0 (#742) commit f966714 Author: Andrii Kostenko <[email protected]> Date: Thu Mar 14 19:45:11 2019 +0300 feat(ripple) mdc-web typescript conversion (#711) commit 0b674f5 Author: Andrii Kostenko <[email protected]> Date: Fri Mar 8 23:54:24 2019 +0300 feat(line-ripple): mdc-web typescript support (#716) * feat(text-field): update to v1.1.1 (#812)

Matt Goo added 8 commits March 27, 2019 12:51

WIP: menu

cae6b6d

WIP: Menu

e237d30

fix: menu with seenshot

f6cadef

WIP: selection menu

14a1183

WIP: menu

e80d458

WIP: getting menulistitem to be interpretted as a listitem

8d0b52a

fix: menu list handleActionitem

cb1694b

fix: add readme

aafb2d1

googlebot added the cla: no label Mar 29, 2019

moog16 changed the base branch from rc0.12.0 to feat/mdcweb-typescript-update March 29, 2019 00:07

feat: add tests

4900f4d

googlebot added cla: yes and removed cla: no labels Mar 29, 2019

Matt Goo added 2 commits March 29, 2019 11:54

fix: lint and test

3abb5f4

fix: add golden

61b076b

moog16 assigned abhiomkar Mar 29, 2019

lucasecdb reviewed Mar 30, 2019

View reviewed changes

Matt Goo added 9 commits April 1, 2019 10:21

fix: Pr changes

05c48dd

Merge branch 'feat/mdcweb-typescript-update' into feat/menu/addcompon…

8a2196f

…ent_try3

WIP: using context to pass list item

6ee5ad7

Merge branch 'feat/mdcweb-typescript-update' into feat/menu/addcompon…

85c0b93

…ent_try3

Merge branch 'feat/menu/addcomponent_try3' into experiemental/menu/co…

93bf167

…ntext

fix: using context instead

c605cef

fix: context is working

bb4c79b

fix: remove context from state

06e2ba6

WIP: tests

8ff2d9f

Matt Goo added 3 commits April 5, 2019 10:23

fix: tests

667ed80

Merge branch 'feat/mdcweb-typescript-update' into feat/menu/addcompon…

f2c0805

…ent_try3

Merge branch 'experiemental/menu/context' into feat/menu/addcomponent…

9ded538

…_try3

moog16 commented Apr 5, 2019

View reviewed changes

Matt Goo added 3 commits April 5, 2019 11:13

fix: commented tests

7521f67

fix: drawer test

b10563c

Merge branch 'feat/mdcweb-typescript-update' into feat/menu/addcompon…

395520d

…ent_try3

lucasecdb reviewed Apr 19, 2019

View reviewed changes

Matt Goo added 3 commits April 19, 2019 16:13

fix: memoize listProps

1b9b7a1

fix: revert esmoduleinterop

8ac8668

Update index.tsx

a5fe91e

lucasecdb reviewed Apr 20, 2019

View reviewed changes

Matt Goo added 3 commits April 22, 2019 17:01

fix: esmoduleinterop

cb75d24

fix: remove * as

949fd9e

fix: screenshots

e70dee4

lucasecdb reviewed Apr 23, 2019

View reviewed changes

fix: move memoizeone

3a8a01e

Matt Goo added 3 commits April 26, 2019 10:06

Merge branch 'feat/mdcweb-typescript-update' into feat/menu/addcompon…

c6930a4

…ent_try3

fix: packagelock

ed4054f

fix: remove menu/index.scss

d074619

Matt Goo added 2 commits April 26, 2019 12:08

fix: add a postinstall to fix react adapter

9c50842

fix: add -f so postinstall doesn't fail

f93bcdf

williamernest approved these changes Apr 26, 2019

View reviewed changes

moog16 merged commit 0f6b071 into feat/mdcweb-typescript-update Apr 26, 2019

moog16 deleted the feat/menu/addcomponent_try3 branch April 30, 2019 18:57

moog16 pushed a commit that referenced this pull request Apr 30, 2019

feat(menu): add component (#786)

7e0f877

feat(menu): add component #786

feat(menu): add component #786

Conversation

moog16 commented Mar 29, 2019 • edited Loading

googlebot commented Mar 29, 2019

codecov-io commented Mar 29, 2019

Codecov Report

codecov-io commented Mar 29, 2019 • edited Loading

Codecov Report

googlebot commented Mar 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasecdb Apr 2, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasecdb Apr 19, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasecdb Apr 23, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moog16 commented Apr 23, 2019

moog16 commented Apr 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moog16 commented Mar 29, 2019 •

edited

Loading

codecov-io commented Mar 29, 2019 •

edited

Loading

lucasecdb Apr 2, 2019 •

edited

Loading

lucasecdb Apr 19, 2019 •

edited

Loading

lucasecdb Apr 23, 2019 •

edited

Loading