Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MDC Web Typings #697

Closed
29 of 34 tasks
moog16 opened this issue Feb 26, 2019 · 13 comments
Closed
29 of 34 tasks

Use MDC Web Typings #697

moog16 opened this issue Feb 26, 2019 · 13 comments

Comments

@moog16
Copy link

moog16 commented Feb 26, 2019

Components with breaking changes

  • tab-bar
  • snackbar
  • button
  • list
  • checkbox
  • fab
  • text field
  • select
  • notched outline

Other components with no breaking changes

  • card
  • chips
  • dialog
  • drawer
  • floating-label
  • icon-button (@ben-mckernan)
  • [ ] layout-grid
  • line-ripple
  • linear-progress
  • menu-surface
  • radio
  • ripple
  • switch
  • tab
  • tab-indicator
  • tab-scroller
  • top-app-bar
  • typography
@gugu
Copy link
Contributor

gugu commented Mar 27, 2019

material-icon has no dependency on mdc-web

@gugu
Copy link
Contributor

gugu commented Mar 29, 2019

image
Bundle size before: 1.74 Mb from material-web
image
Current bundle size: 960 kb from material-web and we can save 560 kb more

@moog16
Copy link
Author

moog16 commented Mar 29, 2019

Are you saying by updating to the latest, we're cutting ~70%??

@gugu
Copy link
Contributor

gugu commented Mar 29, 2019

Yes. That's why I'm working on it - I want to reduce bundle size in my project

@gugu
Copy link
Contributor

gugu commented Mar 29, 2019

But it is mdc-web only, @material/react-* will have the same size

@moog16
Copy link
Author

moog16 commented Mar 29, 2019

Right right - it must be the tree shaking feature that we added in v1. Then hopefully we can get back to the all-in-one package. Also I really appreciate your work on this!

@gugu
Copy link
Contributor

gugu commented Mar 31, 2019

Is there anything left with:

  1. snackbar, button, tab-bar (I did not find changes)
  2. layout-grid - last released version is v0.41

@moog16
Copy link
Author

moog16 commented Apr 1, 2019

  • I think you updated tab-bar already
  • and you're right - snackbar was developed during v0.43.0, which is when the breaking change was introduced.
  • this leaves notched-outline, text-field, select (I'm working on it), button (I opened the PR), and icon-button (@ben-mckernan).

We're looking good to go for releasing in v0.12.0!

@gugu
Copy link
Contributor

gugu commented Apr 1, 2019

I'll start text field in this case. Notched outline is changed, but textfield needs to be changed as well to support it correctly

@moog16
Copy link
Author

moog16 commented Apr 1, 2019

correct...text-field will take a bit of time I'm sure. Once that is done, we should update all the other packages @v1 --> v1.1.0 or v1.0.1 (whatever is latest).

@ghost
Copy link

ghost commented Apr 16, 2019

@gugu
Oh my god, are you already start to update text-field?
If you already working on it, I'll close this PR(#812).

@gugu
Copy link
Contributor

gugu commented Apr 16, 2019

No, I don't

@moog16
Copy link
Author

moog16 commented May 28, 2019

This should have been closed when 0.12.0 was released.

@moog16 moog16 closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants