Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: patrick91-patch-1 #78

Closed
wants to merge 10 commits into from
Closed

Conversation

moog16
Copy link

@moog16 moog16 commented May 29, 2018

FOR SCREENSHOT TESTS ONLY - DO NOT MERGE

related #74

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@patrick91
Copy link
Contributor

patrick91 commented May 29, 2018

I signed it!

EDIT: @moog16 looks like the CLA needs a manual action :)

@moog16
Copy link
Author

moog16 commented May 29, 2018

Hmmm...I reread the message and it looks like it is going to stay in this state. We just have to get this tests to run now.

@codecov-io
Copy link

codecov-io commented May 29, 2018

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          18       18           
  Lines         617      617           
  Branches       49       49           
=======================================
  Hits          610      610           
  Misses          7        7
Impacted Files Coverage Δ
packages/button/index.js 92.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbbbe8...9908860. Read the comment docs.

@moog16
Copy link
Author

moog16 commented May 30, 2018

Closing for #74

@moog16 moog16 closed this May 30, 2018
@moog16 moog16 deleted the patrick91-patch-1-tests branch May 30, 2018 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants