Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for outlined buttons #74

Merged
merged 3 commits into from
May 30, 2018

Conversation

patrick91
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@patrick91
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@kfranqueiro
Copy link

Thanks for the PR. Outlined buttons were actually renamed from stroked, so this PR should replace any instances of stroked with outlined. Currently both exist in this PR.

See #57.

cc @moog16 since he entered all of the tasks necessary for upgrading to MDC Web 0.35.

@patrick91
Copy link
Contributor Author

@kfranqueiro I didn't notice! Thanks, I've updated :)

@codecov-io
Copy link

codecov-io commented May 29, 2018

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          18       18           
  Lines         617      617           
  Branches       49       49           
=======================================
  Hits          610      610           
  Misses          7        7
Impacted Files Coverage Δ
packages/button/index.js 92.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbbbe8...ae09640. Read the comment docs.

@moog16
Copy link

moog16 commented May 29, 2018

Changes look good to me. I'm going to run it on my side and get the screenshot tests working since #71 is still an issue.

Because of #71 you cannot run the tests against TravisCI. So what I'll do is:

  1. fork your branch
  2. create a PR
  3. Link this PR and the new PR together
  4. Once tests pass I will close the new PR and merge this one (to give you the credit you deserve).

@moog16
Copy link

moog16 commented May 29, 2018

Related screenshot tests PR: #78.

@patrick91 could you please sign it?

@moog16
Copy link

moog16 commented May 30, 2018

@patrick91 #78 tests are passing! Will merge :)

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good per #78

@moog16 moog16 merged commit f612388 into material-components:master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants