Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE Tests: Gugu patch 3 #625

Closed
wants to merge 8 commits into from
Closed

DO NOT MERGE Tests: Gugu patch 3 #625

wants to merge 8 commits into from

Conversation

moog16
Copy link

@moog16 moog16 commented Jan 19, 2019

tests for #622

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@moog16 moog16 changed the base branch from master to rc0.9.0 January 19, 2019 17:42
@codecov-io
Copy link

codecov-io commented Jan 19, 2019

Codecov Report

Merging #625 into rc0.9.0 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           rc0.9.0     #625      +/-   ##
===========================================
+ Coverage    94.44%   94.45%   +0.01%     
===========================================
  Files           61       61              
  Lines         2575     2580       +5     
  Branches       376      380       +4     
===========================================
+ Hits          2432     2437       +5     
  Misses          50       50              
  Partials        93       93
Impacted Files Coverage Δ
packages/button/index.tsx 93.33% <100%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e216e...45388b2. Read the comment docs.

Matt Goo added 2 commits January 19, 2019 10:09
@moog16 moog16 closed this Jan 22, 2019
@moog16 moog16 deleted the gugu-patch-3 branch January 23, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants