-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDC button trailing icon support #622
Conversation
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=========================================
+ Coverage 94.49% 94.5% +0.01%
=========================================
Files 61 61
Lines 2560 2565 +5
Branches 371 375 +4
=========================================
+ Hits 2419 2424 +5
Misses 50 50
Partials 91 91
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also requires unit tests
I made these changes and added some simple test. This morning I'll check if there are more tests needed. If yes - I will add them. And retest module in our application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add one screenshot test for button
Left some comments, but I think once those are addressed it should be enough. |
Done |
Done |
#625 tests passing...looks good! |
Now MDC-web supports trailing icon
https://github.com/material-components/material-components-web/tree/master/packages/mdc-button#trailing-icon