Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDC button trailing icon support #622

Merged
merged 7 commits into from
Jan 22, 2019

Conversation

gugu
Copy link
Contributor

@gugu gugu commented Jan 17, 2019

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #622 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #622      +/-   ##
=========================================
+ Coverage   94.49%   94.5%   +0.01%     
=========================================
  Files          61      61              
  Lines        2560    2565       +5     
  Branches      371     375       +4     
=========================================
+ Hits         2419    2424       +5     
  Misses         50      50              
  Partials       91      91
Impacted Files Coverage Δ
packages/button/index.tsx 93.33% <100%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d08700...966e141. Read the comment docs.

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also requires unit tests

packages/button/index.tsx Outdated Show resolved Hide resolved
packages/button/index.tsx Outdated Show resolved Hide resolved
packages/button/package.json Show resolved Hide resolved
@gugu
Copy link
Contributor Author

gugu commented Jan 18, 2019

I made these changes and added some simple test. This morning I'll check if there are more tests needed. If yes - I will add them. And retest module in our application

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add one screenshot test for button

@moog16
Copy link

moog16 commented Jan 19, 2019

Left some comments, but I think once those are addressed it should be enough.

@gugu
Copy link
Contributor Author

gugu commented Jan 19, 2019

Done

@moog16
Copy link

moog16 commented Jan 19, 2019

@gugu please update button golden to the same as this: #625

@gugu
Copy link
Contributor Author

gugu commented Jan 20, 2019

Done

@moog16
Copy link

moog16 commented Jan 22, 2019

#625 tests passing...looks good!

@moog16 moog16 changed the base branch from master to rc0.9.0 January 22, 2019 17:55
@moog16 moog16 merged commit 58b99e4 into material-components:rc0.9.0 Jan 22, 2019
moog16 pushed a commit that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants