Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,22 @@
# write your code here
import os


def move_file(command: str) -> None:
file_name = command.split()[1]
new_path = command.split()[2]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more descriptive variable name instead of file_name to better convey its purpose, as per the checklist item: 'Use descriptive and correct variable names.'

path_list = new_path.split("/")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more descriptive variable name instead of new_path to better convey its purpose, as per the checklist item: 'Use descriptive and correct variable names.'


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of splitting the path manually, use os.path.join to concatenate parts of the path. This ensures cross-platform compatibility, as per the checklist item: 'Use os.path.join to concatenate parts of the path.'

if command.split()[0] == "mv":
if len(path_list) > 1:
new_dir = os.path.dirname(new_path)
if not os.path.exists(new_dir):
os.makedirs(new_dir)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be cautious when using os.makedirs to create directories, as attempting to create a directory that already exists will lead to an error. Consider using os.makedirs(new_dir, exist_ok=True) to avoid this issue, as per the checklist item: 'Notice that if you will try to create the directory already exists then it will lead to an error.'

with (
open(file_name, "r") as file_out,
open(new_path, "w") as file_in
):
file_in.write(file_out.read())

if os.path.exists(file_name):
os.remove(file_name)
Loading