Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented py-lockdown-cafe #545

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions app/cafe.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import datetime

from app.errors import (NotVaccinatedError,
OutdatedVaccineError,
NotWearingMaskError)


class Cafe:
def __init__(self, name: str) -> None:
self.name = name

def visit_cafe(self,
visitor: dict
) -> (str

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same in other similar cases

| NotVaccinatedError
| OutdatedVaccineError
| NotWearingMaskError):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function doesn't return errors it raises them


if "vaccine" not in visitor:
raise NotVaccinatedError

current_date = datetime.datetime.now().date()
if visitor["vaccine"]["expiration_date"] < current_date:
raise OutdatedVaccineError

if not visitor.get("wearing_a_mask", False):
raise NotWearingMaskError(masks_to_buy=0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's better to use a default value for your custom error?


return f"Welcome to {self.name}"
20 changes: 20 additions & 0 deletions app/errors.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
class VaccineError(Exception):
def __str__(self) -> str:
return "All friends should be vaccinated"


class NotVaccinatedError(VaccineError):
pass


class OutdatedVaccineError(VaccineError):
pass


class NotWearingMaskError(Exception):
def __init__(self, masks_to_buy: int) -> None:
self.masks_to_buy = masks_to_buy
super().__init__()

def __str__(self) -> str:
return f"Friends should buy {self.masks_to_buy} masks"
26 changes: 25 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,25 @@
# write your code here
from app.cafe import Cafe
from app.errors import NotWearingMaskError, VaccineError


def go_to_cafe(friends: list,
cafe: Cafe
) -> str | VaccineError:

not_wearing_mask_error = None

for friend in friends:
try:
cafe.visit_cafe(friend)
except VaccineError as e:
return str(e)
except NotWearingMaskError as e:
if not not_wearing_mask_error:
not_wearing_mask_error = e
if not_wearing_mask_error:
not_wearing_mask_error.masks_to_buy += 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why didn't use else?


if not_wearing_mask_error is not None:
return str(not_wearing_mask_error)

return f"Friends can go to {cafe.name}"
Loading