Implemented py-lockdown-cafe #545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serhii-Leonenko
suggested changes
Aug 21, 2023
app/cafe.py
Outdated
Comment on lines
12
to
17
| def visit_cafe(self, | ||
| visitor: dict | ||
| ) -> (str | ||
| | NotVaccinatedError | ||
| | OutdatedVaccineError | ||
| | NotWearingMaskError): |
There was a problem hiding this comment.
the function doesn't return errors it raises them
app/cafe.py
Outdated
Comment on lines
12
to
14
| def visit_cafe(self, | ||
| visitor: dict | ||
| ) -> (str |
There was a problem hiding this comment.
the same in other similar cases
app/cafe.py
Outdated
| raise OutdatedVaccineError | ||
|
|
||
| if not visitor.get("wearing_a_mask", False): | ||
| raise NotWearingMaskError(masks_to_buy=0) |
There was a problem hiding this comment.
maybe it's better to use a default value for your custom error?
| except NotWearingMaskError as e: | ||
| if not not_wearing_mask_error: | ||
| not_wearing_mask_error = e | ||
| if not_wearing_mask_error: |
Serhii-Leonenko
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.