Append relative base href to siteURL #99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Favicon extraction fails when the website's
base href
is set to a relative URL. For example, printables.com:In this case fetching the icons fails because only the relative URL is used:
Note all the "no Host in request URL" errors. This PR should fix this by appending relative
base href
values tositeURL
:Apologies in advance if the code is not up to best practices, this is literally my first time writing Golang.