Append relative base href to siteURL (#99)

mat · May 17, 2024 · 22baa9a · 22baa9a
1 parent 122de2a
commit 22baa9a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/besticon/besticon_test.go b/besticon/besticon_test.go
@@ -137,6 +137,14 @@ func TestFetchIcons(t *testing.T) {
 			{"https://www.xing.com/assets/frontend_minified/img/shared/xing_r1.ico", 16, "ico"},
 			{"https://www.xing.com/favicon.ico", 16, "ico"},
 		}},
+
+		// https://printables.com - <base href="/" - https://github.com/mat/besticon/pull/99
+		{"https://printables.com", []testFetchIcon{
+			{"https://www.printables.com/assets/favicons/apple-touch-icon.png", 180, "png"},
+			{"https://www.printables.com/favicon.ico", 48, "ico"},
+			{"https://www.printables.com/assets/favicons/favicon-32x32.png", 32, "png"},
+			{"https://www.printables.com/assets/favicons/favicon-16x16.png", 16, "png"},
+		}},
 	}
 
 	for _, test := range tests {

diff --git a/besticon/extract.go b/besticon/extract.go
@@ -67,6 +67,9 @@ func findIconLinks(siteURL *url.URL, html []byte) ([]string, error) {
 func determineBaseURL(siteURL *url.URL, doc *goquery.Document) *url.URL {
 	baseTagHref := extractBaseTag(doc)
 	if baseTagHref != "" {
+        if strings.HasPrefix(baseTagHref, "/") {
+            return siteURL.JoinPath(baseTagHref)
+        }
 		baseTagURL, e := url.Parse(baseTagHref)
 		if e != nil {
 			return siteURL

diff --git a/besticon/testdata/printables.com.vcr b/besticon/testdata/printables.com.vcr