Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Maximum height for posts behind content warning #166

Open
sk22 opened this issue May 15, 2022 · 2 comments
Open

Feature: Maximum height for posts behind content warning #166

sk22 opened this issue May 15, 2022 · 2 comments
Labels
ui/ux related Needs review by UI/UX people

Comments

@sk22
Copy link
Contributor

sk22 commented May 15, 2022

Screenshot_20220515-214645736

The post in the screenshot is way larger, I think the problem is obvious. There really should be a maximum height (that ideally doesn't cut off very long content warnings either) for posts behind content warnings.

@grishka grishka added the ui/ux related Needs review by UI/UX people label May 15, 2022
sk22 added a commit to sk22/megalodon that referenced this issue Nov 7, 2022
@sk22
Copy link
Contributor Author

sk22 commented Nov 7, 2022

Fixed this in my fork, but not creating a pull request here for now because #22 (comment)

@waldyrious
Copy link

IMO a nicer solution could be adjusting the placement of the spoiler tag text so that it's always on-screen, without changing the height of the spoiler area. Quoting myself from #419:

Ideally the text should have a "sticky" positioning, so that it can still be in the vertical center of the post when that doesn't place it off-screen, but would otherwise remain visible (stuck to the top or the bottom of the visible area).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux related Needs review by UI/UX people
Projects
None yet
Development

No branches or pull requests

3 participants