Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max width doesn't suffice for tall images #167

Closed
sk22 opened this issue May 15, 2022 · 0 comments
Closed

Max width doesn't suffice for tall images #167

sk22 opened this issue May 15, 2022 · 0 comments

Comments

@sk22
Copy link
Contributor

sk22 commented May 15, 2022

The MAX_WIDTH defined in ImageAttachmentFrameLayout (as 400 dp) isn't ideal for determining whether an image should be displayed with full width or not, because it doesn't really help with very tall images (like screenshots). Maybe the image's aspect ratio is more suited for determining this?
Or maybe there could be a maximum height for images, so tall images are displayed centered in cases where exceeded.
This is an issue because, like in #166, possibly having to scroll down multiple screens because someone posted a very tall or narrow image imo isn't acceptable from an UX standpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant