Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-27], Add unobserve to componentWillUnmount #32

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

matsilva
Copy link
Contributor

@matsilva matsilva commented Mar 27, 2018

This will resolve this issue: #27

You can see others are working around this by using a mounted flag: https://github.com/recharts/recharts/blob/master/src/component/ResponsiveContainer.js#L71

@maslianok maslianok merged commit 13e168e into maslianok:master Mar 28, 2018
@maslianok
Copy link
Owner

maslianok commented Mar 28, 2018

Closes #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants