2.0 triggers resize when component unmount

[rockmandash]

2.0 triggers resize when component unmount
So the resize remain, if you modify props in -onResize, things will break!

[maslianok]

Can you provide a code snippet so I can reproduce this issue?

[rockmandash]

I think I'm wrong.

[cephirothdy2j]

I'm seeing this issue as well. Simply put, the resize method fires when the component unmounts, which causes the classic React error:

Warning: Can only update a mounted or mounting component. This usually means you called setState, replaceState, or forceUpdate on an unmounted component. This is a no-op.

[lh0x00]

@cephirothdy2j hi, please tell me a example code, maybe can I help you ^^

[matsilva]

I ran into the same issue and could resolve by calling unobserve in componentWillUnmount.

Before I did this, I almost did something similar to what the folks behind recharts did https://github.com/recharts/recharts/blob/master/src/component/ResponsiveContainer.js#L71

Notice they are setting a mounted flag to fix this issue.

[cephirothdy2j]

Setting the "mounted" flag is what I ended up doing as well.

[matsilva]

#32 @cephirothdy2j can you build and test in your project to see if this works?

[cephirothdy2j]

Yes, that PR appears to resolve the issue. 👍

[matsilva]

Yes, that PR appears to resolve the issue. 👍

Thanks for checking it out.

[maslianok]

Thanks to everyone for your involvement!

@matsilva Huge thanks for the PR! :)

[maslianok]

[email protected] published to npm with this fix!

[matsilva]

[email protected] published to npm with this fix!

Awesome! Thanks a lot.