Some fixes applied, to be regenerated #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masesdevelopers
commented
May 31, 2024
| @@ -785,7 +785,7 @@ public partial class NumberFormatterSettings : MASES.JCOBridge.C2JBridge.JVMBrid | |||
| /// <see href="https://developer.android.com/reference/android/icu/number/NumberFormatterSettings.html"/> | |||
| /// </summary> | |||
| /// <typeparam name="T"></typeparam> | |||
| public partial class NumberFormatterSettings<T> : MASES.JCOBridge.C2JBridge.JVMBridgeBase<NumberFormatterSettings<T>> where T: Android.Icu.Number.NumberFormatterSettings<?> | |||
There was a problem hiding this comment.
The type is reported as ? instead of T
| @@ -54,10 +54,6 @@ public UnicodeSetIterator(Android.Icu.Text.UnicodeSet arg0) | |||
| /// </summary> | |||
| public int codepointEnd { get { return IGetField<int>("codepointEnd"); } set { ISetField("codepointEnd", value); } } | |||
| /// <summary> | |||
| /// <see href="https://developer.android.com/reference/android/icu/text/UnicodeSetIterator.html#string"/> | |||
| /// </summary> | |||
| public Java.Lang.String string { get { return IGetField<Java.Lang.String>("string"); } set { ISetField("string", value); } } | |||
There was a problem hiding this comment.
There are many properties whose name clashes with C# language keyword
| @@ -1952,7 +1952,7 @@ public partial class Range : MASES.JCOBridge.C2JBridge.JVMBridgeBase<Range> | |||
| /// <see href="https://developer.android.com/reference/android/util/Range.html"/> | |||
| /// </summary> | |||
| /// <typeparam name="T"></typeparam> | |||
| public partial class Range<T> : MASES.JCOBridge.C2JBridge.JVMBridgeBase<Range<T>> where T: Java.Lang.Comparable<? super T> | |||
There was a problem hiding this comment.
Reports ? super T instead of T
masesdevelopers
deleted the
7-code-compilation-reports-errors-review-the-reflected-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial PR with some updates; needs a new class generation and maybe some reviews of JNetReflector
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: