Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netdroid class reflection needs some updates from JNetReflector #426

Closed
masesdevelopers opened this issue May 31, 2024 · 4 comments · Fixed by #432, #434, #436, #438 or #440
Closed

Netdroid class reflection needs some updates from JNetReflector #426

masesdevelopers opened this issue May 31, 2024 · 4 comments · Fixed by #432, #434, #436, #438 or #440

Comments

@masesdevelopers
Copy link
Contributor

          Updates needed from JNetReflector

Originally posted by @masesdevelopers in masesgroup/netdroid#8 (review)

See the comments and code changes

@masesdevelopers masesdevelopers changed the title Updates needed from JNetReflector Netdroid class reflection needs some updates from JNetReflector May 31, 2024
@masesdevelopers
Copy link
Contributor Author

In https://github.com/masesgroup/netdroid/blob/dd5981392c2fe2da84bd167eb8ce57c268c96b6d/src/net/Netdroid/Generated/Android/Net/Wifi/WifiManager.cs#L409 the code uses Android.Net.Wifi.WifiConfiguration, but it seems deprecated and not available: the tool does not check if the return type will be not available in the available classes.

@masesdevelopers
Copy link
Contributor Author

The code in https://github.com/masesgroup/netdroid/blob/a1b5d1d5d5e8371a0c58da0df5711292bc0ec476/src/net/Netdroid/Generated/Android/Widget/SimpleAdapter.cs#L376 is like

        public virtual void SetAutofillOptions(params Java.Lang.CharSequence[] arg0)
        {
            
        }

however the handler in https://github.com/masesgroup/netdroid/blob/a1b5d1d5d5e8371a0c58da0df5711292bc0ec476/src/net/Netdroid/Generated/Android/Widget/SimpleAdapter.cs#L364 is empty:

        public System.Action<> OnSetAutofillOptions { get; set; } = null;

and the method invocation in https://github.com/masesgroup/netdroid/blob/a1b5d1d5d5e8371a0c58da0df5711292bc0ec476/src/net/Netdroid/Generated/Android/Widget/SimpleAdapter.cs#L366 is invalid:

        void SetAutofillOptionsEventHandler(object sender, CLRListenerEventArgs<CLREventData<Java.Lang.CharSequence[]>> data)
        {
            var methodToExecute = (OnSetAutofillOptions != null) ? OnSetAutofillOptions : SetAutofillOptions;
            methodToExecute.Invoke();
        }

@masesdevelopers
Copy link
Contributor Author

masesdevelopers added a commit that referenced this issue Jun 3, 2024
* Removed Iterable and Iterator properties, they become always methods

* Update docs

* #426 (comment): solved multiple new() and wrong Direct method
@masesdevelopers masesdevelopers mentioned this issue Jun 3, 2024
9 tasks
@masesdevelopers
Copy link
Contributor Author

masesdevelopers commented Jun 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment