Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace which ends with Internal shall be reflected #17

Closed
mariomastrodicasa opened this issue Mar 9, 2022 · 4 comments · Fixed by #19
Closed

Namespace which ends with Internal shall be reflected #17

mariomastrodicasa opened this issue Mar 9, 2022 · 4 comments · Fixed by #19
Assignees
Labels
bug Something isn't working

Comments

@mariomastrodicasa
Copy link
Contributor

Describe the bug
The core engine does not reflect namespaces which ends with Internal string. Some packages use this kind of namespace to identify public classes which are not part of the public API.

Expected behavior
Reflect this classes

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: All
  • Version: All

Additional context
N/A

@mariomastrodicasa mariomastrodicasa added the bug Something isn't working label Mar 9, 2022
@masesdevelopers
Copy link
Contributor

A feature request shall be opened in JCOReflector project.

@masesdevelopers
Copy link
Contributor

Testing evolution with latest JCOReflector raised a new problem; an internal exception within the engine is not reported even if NuReflector sets:

JobManager.ErrorReporting = ErrorReportingType.Both;

@masesdevelopers
Copy link
Contributor

The latest version reports an incorrect Exception, the internal Exception becomes an ArgumentNullException. Anyway the engine becomes unusable: seems the problem is related to the throw clause moved within the catch which avoids to call the EndOperation handler and consequently does not cleanup the internal state.

@masesdevelopers
Copy link
Contributor

Version 1.9.2 of JCOReflector has a new issue: if an assembly contains classes which does not have a Namespace it raises a NullReferenceException. The exception is raised in https://github.com/masesgroup/JCOReflector/blob/a98ba834e0c092d589bbbd9b6d18613860265c00/src/engine/Reflector.cs#L661

masesdevelopers added a commit to masesdevelopers/NuReflector that referenced this issue Mar 15, 2022
masesdevelopers added a commit that referenced this issue Mar 16, 2022
* #17: added Internal namespace in reflection

* #16: added license in package

* Try to update console reporting for a better output quality

* Extract dependencies in the same root folder of top-level package

* Extract items in any case

* #17: updates with JCOReflector 1.9.2

* #93: save assembly anyway

* Avoid help in GitHub actions

* Updates for duplicated files in folder

* #17 (comment): solved

* #16 (comment)

* Extract load information

* Write full exception log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants