Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the JobManager to correctly report the right exception and cleanup the JobManager state #91

Closed
masesdevelopers opened this issue Mar 12, 2022 · 1 comment · Fixed by #92
Assignees
Labels
bug Something isn't working

Comments

@masesdevelopers
Copy link
Contributor

The latest version reports an incorrect Exception, the internal Exception becomes an ArgumentNullException. Anyway the engine becomes unusable: seems the problem is related to the throw clause moved within the catch which avoids to call the EndOperation handler and consequently does not cleanup the internal state.

Originally posted by @masesdevelopers in masesgroup/NuReflector#17 (comment)

@masesdevelopers masesdevelopers self-assigned this Mar 12, 2022
@masesdevelopers masesdevelopers added the bug Something isn't working label Mar 12, 2022
@masesdevelopers
Copy link
Contributor Author

The following

public static ErrorReportingType ErrorReporting { get; set; }
becomes a bool property and
internal static void EndOperation(EndOperationEventArgs arg)
will be invoked in any case.
Plus will be added a new method Clean to reset the state if something goes wrong.

masesdevelopers added a commit to masesdevelopers/JCOReflector that referenced this issue Mar 13, 2022
masesdevelopers added a commit to masesdevelopers/JCOReflector that referenced this issue Mar 14, 2022
masesdevelopers added a commit that referenced this issue Mar 14, 2022
* #91: update engine with ReportException

* docs fix

* #91: added Reset

* #92: Added assembly list file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant