🔖 Release 1.8.7

[phatblat]

Release branch for 1.8.7.

This branch includes the new release workflow #510.

[phatblat]

I've published a build from this branch on the releases page:
https://github.com/mas-cli/mas/releases/tag/v1.8.7-beta.1

[rgoldberg]

@phatblat

Not sure if you saw my comment:

#505 (comment)

I think testing & releasing #496 or #503 (the 1-line code change is exactly the same in both of them) should solve the main problem of iOS app versions showing up as Mac app versions, while 1.8.7 beta 1 didn't fix it for me (on macOS 12.7.x on an Intel).

Let me know if I can help get some or all of the fixes out.

Happy new year.

Thanks.

[phatblat]

The release failed again. Looks like the issue was with the --fork-org mas-cli option.

+ brew bump-formula-pr --tag=v1.8.7 --revision=4405807010987802c0967bbf349c08808062b824 --strict --verbose --online --no-browse --fork-org mas-cli mas
/opt/homebrew/Library/Taps/homebrew/homebrew-core ~/work/mas/mas
Updating homebrew/core formula with a PR
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.5/bin/bundle clean
==> replace /tag:(\s+")v1.8.6(?=")/ with "tag:\\1v1.8.7\\2"
==> replace "560c89af2c1fdf0da9982a085e19bb6f5f9ad2d0" with "4405807010987802c0967bbf349c08808062b824"
Error: Unable to fork: GitHub API Error: Must have admin rights to Repository.
HOMEBREW_GITHUB_API_TOKEN may be invalid or expired; check:
  https://github.com/settings/tokens
!
Error: Process completed with exit code 1.

[toobuntu]

In mas-cli/homebrew-tap#45 is the vv correct?

-    root_url "https://github.com/mas-cli/mas/releases/download/v1.8.7-beta.1"
+    root_url "https://github.com/mas-cli/mas/releases/download/vv1.8.7"

[phatblat]

In mas-cli/homebrew-tap#45 is the vv correct?

Nope. Thanks for calling this out, @toobuntu!

[phatblat]

Got a little bit further by adding repo the scopes on the PAT I created for the HOMEBREW_GITHUB_API_TOKEN secret.

 brew bump-formula-pr --tag=v1.8.7 --revision=4405807010987802c0967bbf349c08808062b824 --strict --verbose --online --no-browse --fork-org mas-cli mas
/opt/homebrew/Library/Taps/homebrew/homebrew-core ~/work/mas/mas
Updating homebrew/core formula with a PR

/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.5/bin/bundle clean
==> replace /tag:(\s+")v1.8.6(?=")/ with "tag:\\1v1.8.7\\2"
==> replace "560c89af2c1fdf0da9982a085e19bb6f5f9ad2d0" with "4405807010987802c0967bbf349c08808062b824"
git add /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/m/mas.rb
git checkout --no-track -b bump-mas-1.8.7 origin/master
Switched to a new branch 'bump-mas-1.8.7'
M	Formula/m/mas.rb
git commit --no-edit --verbose --message=mas 1.8.7 -- /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/m/mas.rb
[bump-mas-1.8.7 2dfea1852ff] mas 1.8.7
 1 file changed, 2 insertions(+), 2 deletions(-)
remote: 
remote: Create a pull request for 'bump-mas-1.8.7' on GitHub by visiting:        
remote:      https://github.com/mas-cli/homebrew-core-1/pull/new/bump-mas-1.8.7        
remote: 
To https://github.com/mas-cli/homebrew-core-1.git
 * [new branch]              bump-mas-1.8.7 -> bump-mas-1.8.7
branch 'bump-mas-1.8.7' set up to track '***github.com/mas-cli/homebrew-core-1.git/bump-mas-1.8.7'.
git checkout --quiet -
Error: Unable to open pull request: Validation Failed: [{"resource"=>"PullRequest", "field"=>"head", "code"=>"invalid"}]!
Error: Process completed with exit code 1.

[rgoldberg]

I should investigate release.yml more, but I might not have time to do too much more now, so I figured I'd submit my review. I might change/add a few comments.

[rgoldberg]

@phatblat Probably simplest to just accept this PR to merge it into main, then to open individual PRs to make changes, instead of fixing in this PR.

[phatblat]

Looks like 1.8.7 was released in Homebrew/homebrew-core#196567