🖥️ Only search, outdated and update macOS apps #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've published a build with this on the releases page: |
This was referenced Nov 29, 2023
|
For 1.8.7 Beta 1 on macOS 12.7.2 on Intel: 3.3.0 & 10.11 are the most recent versions that can be installed on my machine, so the above output seems incorrect. When I tested the change from #496 & #503 (they have the exact same one-line change) in Xcode 14.2, Can you try #496 and/or #503 in Xcode? If that works for you, can you release 1.8.7 Beta 2 with just that change, not including the other changes from this PR? Thanks. Sorry for the delay. I should be able to quickly test anything you release in the upcoming weeks much more rapidly than my 3-week delay for 1.8.7 Beta 1. |
This was referenced Dec 29, 2023
Merged
|
Updated this branch from |
- swift-argument-parser (1.3.0) - swift-format (5.9) - swift-syntax (0.50700.1) - swift-tools-support-core (5.9)
|
I'm not getting the same CoreData logs, but when running tests from this branch locally, it stops as |
|
Yep, that was it. This test was disabled because it isn't properly mocked. |
Stalls test when a MAS auth dialog stalls tests. Need more mocking.
Resolves unused protocol method lint warnings by moving updated implementations back to StoreSearch. Added `country` to MasStoreSearch, set to fixed fvalue for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #336, #491
Obviates #496, #503, #504
Since the introduction of iOS apps on macOS (running on Apple Silicon),
mashas had no knowledge of the difference and occasionally shows iOS apps in search results or attempts to update macOS apps with the iOS app metadata and fails with confusing errors.This PR builds on @chris-araman's research and simply filters out iOS apps for now. I'm opening this as a draft for review and to show the community that I'm looking into resolving these issues, but this change will need some testing before release.
Explicit support for installing and updating iOS apps can be added, but that work will be outside this PR.