[Lens] Fix bug with switching from subtype to subtype (elastic#49915) (…

…elastic#49930)
maryia-lapata · Oct 31, 2019 · 1c3f072 · 1c3f072
1 parent 8213aae
commit 1c3f072
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/chart_switch.test.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/chart_switch.test.tsx
@@ -369,7 +369,7 @@ describe('chart_switch', () => {
     );
   });
 
-  it('should not remove layers if the visualization is not changing', () => {
+  it('should not remove layers when switching between subtypes', () => {
     const dispatch = jest.fn();
     const frame = mockFrame(['a', 'b', 'c']);
     const visualizations = mockVisualizations();
@@ -397,6 +397,7 @@ describe('chart_switch', () => {
         initialState: 'therebedragons',
       })
     );
+    expect(frame.removeLayers).not.toHaveBeenCalled();
   });
 
   it('should switch to the updated datasource state', () => {

diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/chart_switch.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/chart_switch.tsx
@@ -28,6 +28,7 @@ interface VisualizationSelection {
   dataLoss: 'nothing' | 'layers' | 'everything' | 'columns';
   datasourceId?: string;
   datasourceState?: unknown;
+  sameDatasources?: boolean;
 }
 
 interface Props {
@@ -89,7 +90,10 @@ export function ChartSwitch(props: Props) {
       'SWITCH_VISUALIZATION'
     );
 
-    if (!selection.datasourceId || selection.dataLoss === 'everything') {
+    if (
+      (!selection.datasourceId && !selection.sameDatasources) ||
+      selection.dataLoss === 'everything'
+    ) {
       props.framePublicAPI.removeLayers(Object.keys(props.framePublicAPI.datasourceLayers));
     }
   };
@@ -109,6 +113,7 @@ export function ChartSwitch(props: Props) {
         dataLoss: 'nothing',
         keptLayerIds: Object.keys(props.framePublicAPI.datasourceLayers),
         getVisualizationState: () => switchVisType(subVisualizationId, props.visualizationState),
+        sameDatasources: true,
       };
     }