[Lens] Fix crash when switching from subtype to subtype #49915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
changed the title
wylieconlon
commented
Oct 31, 2019
| @@ -397,6 +397,7 @@ describe('chart_switch', () => { | |||
| initialState: 'therebedragons', | |||
| }) | |||
| ); | |||
| expect(frame.removeLayers).not.toHaveBeenCalled(); | |||
There was a problem hiding this comment.
I had accidentally removed this line in the test, which was the whole point
💚 Build Succeeded |
This was referenced Oct 31, 2019
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Oct 31, 2019
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Oct 31, 2019
wylieconlon
pushed a commit
that referenced
this pull request
Oct 31, 2019
wylieconlon
pushed a commit
that referenced
this pull request
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash that happens every time in the chart switcher when switching from a type like Bar to Line. This bug happened because the suggestion being build did not include
datasourceId, which was also used in the logic to remove layers. This still lets us clear layers when switching between two separate datasources without breaking the same-datasource case.